third_party/WebKit/Source/core/editing/EditingStyle.cpp - Issue 2046243002: Removed the non-const version of PropertyReference::value()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStyle.cpp

Issue 2046243002: Removed the non-const version of PropertyReference::value() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_csscursorimagevalue_reresolveurl_const

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | third_party/WebKit/Source/core/frame/FrameSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingStyle.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingStyle.cpp b/third_party/WebKit/Source/core/editing/EditingStyle.cpp

index 5106669b4c8fa1eb162075618f55af49dd171ad1..6948e69376abcb1a958c49fb35f98644e83110d8 100644

--- a/third_party/WebKit/Source/core/editing/EditingStyle.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingStyle.cpp

@@ -1221,7 +1221,7 @@ void EditingStyle::mergeStyleFromRulesForSerialization(Element* element)

unsigned propertyCount = m_mutableStyle->propertyCount();

for (unsigned i = 0; i < propertyCount; ++i) {

StylePropertySet::PropertyReference property = m_mutableStyle->propertyAt(i);

- CSSValue* value = property.value();

+ const CSSValue* value = property.value();

if (!value->isPrimitiveValue())

continue;

if (toCSSPrimitiveValue(value)->isPercentage()) {