third_party/WebKit/Source/core/css/StylePropertySet.h - Issue 2046243002: Removed the non-const version of PropertyReference::value()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.h

Issue 2046243002: Removed the non-const version of PropertyReference::value() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_csscursorimagevalue_reresolveurl_const

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/RuleFeature.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/StylePropertySet.h

diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.h b/third_party/WebKit/Source/core/css/StylePropertySet.h

index 179f53e07eb85b76a2bd8cc2b0fbf375d1db904a..3e0b8a0ba969c04bbfb8b7cff80d1c25c6091c77 100644

--- a/third_party/WebKit/Source/core/css/StylePropertySet.h

+++ b/third_party/WebKit/Source/core/css/StylePropertySet.h

@@ -64,8 +64,6 @@ public:

bool isImplicit() const { return propertyMetadata().m_implicit; }

const CSSValue* value() const { return propertyValue(); }

- // FIXME: We should try to remove this mutable overload.

- CSSValue* value() { return const_cast<CSSValue*>(propertyValue()); }

// FIXME: Remove this.

CSSProperty toCSSProperty() const { return CSSProperty(propertyMetadata(), *propertyValue()); }

« no previous file with comments | « third_party/WebKit/Source/core/css/RuleFeature.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »