Make CSSPropertyParser::addProperty take a const CSSValue&

Make CSSPropertyParser::addProperty take a const CSSValue&

Make CSSPropertyParser::addProperty take a const CSSValue&. This is an
entirely mechanical change, is more semantically correct and safe, and
is pre-work for making CSSPropertyParser::parseSingleValue return a
const CSSValue*.

This patch also involved making MutableStylePropertySet::setProperty()
and some StringKeyframe methods take/return a const CSSValue ptr.

BUG=526586
Committed: https://crrev.com/b39abd27bae2248520b90fe932504afbbd7debd6
Cr-Commit-Position: refs/heads/master@{#405060}

[sashab, 2016-06-06 01:33:42]

sashab@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-06-06 02:58:53]

On 2016/06/06 01:33:43, sashab wrote:

I guess this should be const ref because it's nonnull?

[sashab, 2016-06-06 03:33:36]

Description was changed from

==========
Make CSSPropertyParser::addProperty take a const CSSValue*

Make CSSPropertyParser::addProperty take a const CSSValue*. This is more
semantically correct and safe, and is pre-work for making
CSSPropertyParser::parseSingleValue return a const CSSValue*.

BUG=526586
==========

to

==========
Make CSSPropertyParser::addProperty take a const CSSValue&

Make CSSPropertyParser::addProperty take a const CSSValue&. This is more
semantically correct and safe, and is pre-work for making
CSSPropertyParser::parseSingleValue return a const CSSValue*.

BUG=526586
==========

[sashab, 2016-06-06 03:34:29]

Make return reference instead & updated CL description. Will also make
CSSProperty() take a const reference in a future patch which will eliminate the
need for taking the address.

[sashab, 2016-06-06 04:23:40]

Errr.. Hold on. Putting this patch on hold until I've done some prereq work to
make the const ref stuff work...

[sashab, 2016-06-06 04:37:07]

Description was changed from

==========
Make CSSPropertyParser::addProperty take a const CSSValue&

Make CSSPropertyParser::addProperty take a const CSSValue&. This is more
semantically correct and safe, and is pre-work for making
CSSPropertyParser::parseSingleValue return a const CSSValue*.

BUG=526586
==========

to

==========
Make CSSPropertyParser::addProperty take a const CSSValue&

Make CSSPropertyParser::addProperty take a const CSSValue&. This is an
entirely mechanical change, is more semantically correct and safe, and
is pre-work for making CSSPropertyParser::parseSingleValue return a
const CSSValue*.

This patch also involved making MutableStylePropertySet::setProperty()
and some StringKeyframe methods take/return a const CSSValue ptr.

BUG=526586
==========

[sashab, 2016-06-06 04:38:26]

Ok... That all looks right. It now goes on top of the StringKeyframe stuff in
crrev.com/2043573002.

[Timothy Loh, 2016-06-07 03:58:03]

lgtm

[sashab, 2016-07-13 06:39:38]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-07-13 06:39:39]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2042653002/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-13 06:39:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 07:04:25]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-07-13 07:04:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 07:07:13]

Description was changed from

==========
Make CSSPropertyParser::addProperty take a const CSSValue&

Make CSSPropertyParser::addProperty take a const CSSValue&. This is an
entirely mechanical change, is more semantically correct and safe, and
is pre-work for making CSSPropertyParser::parseSingleValue return a
const CSSValue*.

This patch also involved making MutableStylePropertySet::setProperty()
and some StringKeyframe methods take/return a const CSSValue ptr.

BUG=526586
==========

to

==========
Make CSSPropertyParser::addProperty take a const CSSValue&

Make CSSPropertyParser::addProperty take a const CSSValue&. This is an
entirely mechanical change, is more semantically correct and safe, and
is pre-work for making CSSPropertyParser::parseSingleValue return a
const CSSValue*.

This patch also involved making MutableStylePropertySet::setProperty()
and some StringKeyframe methods take/return a const CSSValue ptr.

BUG=526586

Committed: https://crrev.com/b39abd27bae2248520b90fe932504afbbd7debd6
Cr-Commit-Position: refs/heads/master@{#405060}
==========

[commit-bot: I haz the power, 2016-07-13 07:07:14]

Patchset 10 (id:??) landed as
https://crrev.com/b39abd27bae2248520b90fe932504afbbd7debd6
Cr-Commit-Position: refs/heads/master@{#405060}