third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 2042653002: Make CSSPropertyParser::addProperty take a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 2042653002: Make CSSPropertyParser::addProperty take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_and_computedstylemapping_store_const

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySet.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index f2d605ace2f22aa36e96bdc3e6b679f12ab85551..ecd2bcbe6ccc31d7c3e18f82e90c822a3506e36c 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -61,8 +61,8 @@ private:

bool parseViewportDescriptor(CSSPropertyID propId, bool important);

bool parseFontFaceDescriptor(CSSPropertyID);

- void addProperty(CSSPropertyID, CSSPropertyID, CSSValue*, bool important, bool implicit = false);

- void addExpandedPropertyForValue(CSSPropertyID propId, CSSValue*, bool);

+ void addProperty(CSSPropertyID, CSSPropertyID, const CSSValue&, bool important, bool implicit = false);

+ void addExpandedPropertyForValue(CSSPropertyID propId, const CSSValue&, bool);

bool consumeBorder(bool important);