third_party/WebKit/Source/core/css/StylePropertySet.cpp - Issue 2042653002: Make CSSPropertyParser::addProperty take a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.cpp

Issue 2042653002: Make CSSPropertyParser::addProperty take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_and_computedstylemapping_store_const

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySet.h ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/StylePropertySet.cpp

diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.cpp b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

index da2011104f05b9186b55b600b5a4bcb4d182da7b..c4641700f28adbe9fe27c58a544fd6d93e126394 100644

--- a/third_party/WebKit/Source/core/css/StylePropertySet.cpp

+++ b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

@@ -307,7 +307,7 @@ bool MutableStylePropertySet::setProperty(const AtomicString& customPropertyName

return CSSParser::parseValueForCustomProperty(this, customPropertyName, value, important, contextStyleSheet);

}

-void MutableStylePropertySet::setProperty(CSSPropertyID propertyID, CSSValue* value, bool important)

+void MutableStylePropertySet::setProperty(CSSPropertyID propertyID, const CSSValue* value, bool important)

{

StylePropertyShorthand shorthand = shorthandForProperty(propertyID);

if (!shorthand.length()) {