third_party/WebKit/Source/core/css/StylePropertySet.h - Issue 2042653002: Make CSSPropertyParser::addProperty take a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.h

Issue 2042653002: Make CSSPropertyParser::addProperty take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_and_computedstylemapping_store_const

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/StringKeyframe.cpp ('k') | third_party/WebKit/Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/StylePropertySet.h

diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.h b/third_party/WebKit/Source/core/css/StylePropertySet.h

index 8732c54f2d3593acc1906681a12e6345929fd883..91c92b7ed563d4a1f4cbd9e3a3aa9ab38b65434a 100644

--- a/third_party/WebKit/Source/core/css/StylePropertySet.h

+++ b/third_party/WebKit/Source/core/css/StylePropertySet.h

@@ -203,7 +203,7 @@ public:

// These expand shorthand properties into multiple properties.

bool setProperty(CSSPropertyID unresolvedProperty, const String& value, bool important = false, StyleSheetContents* contextStyleSheet = 0);

bool setProperty(const AtomicString& customPropertyName, const String& value, bool important = false, StyleSheetContents* contextStyleSheet = 0);

- void setProperty(CSSPropertyID, CSSValue*, bool important = false);

+ void setProperty(CSSPropertyID, const CSSValue*, bool important = false);

// These do not. FIXME: This is too messy, we can do better.

bool setProperty(CSSPropertyID, CSSValueID identifier, bool important = false);