Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/css/StylePropertySet.cpp

Issue 2042653002: Make CSSPropertyParser::addProperty take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_and_computedstylemapping_store_const
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
4 * Copyright (C) 2011 Research In Motion Limited. All rights reserved. 4 * Copyright (C) 2011 Research In Motion Limited. All rights reserved.
5 * Copyright (C) 2013 Intel Corporation. All rights reserved. 5 * Copyright (C) 2013 Intel Corporation. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 return CSSParser::parseValue(this, unresolvedProperty, value, important, con textStyleSheet); 300 return CSSParser::parseValue(this, unresolvedProperty, value, important, con textStyleSheet);
301 } 301 }
302 302
303 bool MutableStylePropertySet::setProperty(const AtomicString& customPropertyName , const String& value, bool important, StyleSheetContents* contextStyleSheet) 303 bool MutableStylePropertySet::setProperty(const AtomicString& customPropertyName , const String& value, bool important, StyleSheetContents* contextStyleSheet)
304 { 304 {
305 if (value.isEmpty()) 305 if (value.isEmpty())
306 return removeProperty(customPropertyName); 306 return removeProperty(customPropertyName);
307 return CSSParser::parseValueForCustomProperty(this, customPropertyName, valu e, important, contextStyleSheet); 307 return CSSParser::parseValueForCustomProperty(this, customPropertyName, valu e, important, contextStyleSheet);
308 } 308 }
309 309
310 void MutableStylePropertySet::setProperty(CSSPropertyID propertyID, CSSValue* va lue, bool important) 310 void MutableStylePropertySet::setProperty(CSSPropertyID propertyID, const CSSVal ue* value, bool important)
311 { 311 {
312 StylePropertyShorthand shorthand = shorthandForProperty(propertyID); 312 StylePropertyShorthand shorthand = shorthandForProperty(propertyID);
313 if (!shorthand.length()) { 313 if (!shorthand.length()) {
314 setProperty(CSSProperty(propertyID, *value, important)); 314 setProperty(CSSProperty(propertyID, *value, important));
315 return; 315 return;
316 } 316 }
317 317
318 removePropertiesInSet(shorthand.properties(), shorthand.length()); 318 removePropertiesInSet(shorthand.properties(), shorthand.length());
319 319
320 for (unsigned i = 0; i < shorthand.length(); ++i) 320 for (unsigned i = 0; i < shorthand.length(); ++i)
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 { 568 {
569 return new MutableStylePropertySet(cssParserMode); 569 return new MutableStylePropertySet(cssParserMode);
570 } 570 }
571 571
572 MutableStylePropertySet* MutableStylePropertySet::create(const CSSProperty* prop erties, unsigned count) 572 MutableStylePropertySet* MutableStylePropertySet::create(const CSSProperty* prop erties, unsigned count)
573 { 573 {
574 return new MutableStylePropertySet(properties, count); 574 return new MutableStylePropertySet(properties, count);
575 } 575 }
576 576
577 } // namespace blink 577 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySet.h ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698