Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fbae9a940e3e1086437785e55fc5e773a0245692
Cr-Commit-Position: refs/heads/master@{#398230}

[Zhenyao Mo, 2016-06-05 15:15:34]

Description was changed from

==========
Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to
match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
==========

to

==========
Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to
match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-06-05 15:15:35]

Description was changed from

==========
Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to
match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to
match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-06-05 15:16:31]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-05 15:16:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040773002/1

[commit-bot: I haz the power, 2016-06-05 16:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-05 16:18:03]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Zhenyao Mo, 2016-06-06 12:47:47]

kbr,please review.
cwallez: fyi (feel free to review)

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4151: case
GL_RGB5_A1:
I think these are the only packed formats that goes down the gpu path.

[Corentin Wallez, 2016-06-06 15:25:47]

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4151: case
GL_RGB5_A1:
On 2016/06/06 at 12:47:47, Zhenyao Mo wrote:
> I think these are the only packed formats that goes down the gpu path.

What is the alternative path?

[Zhenyao Mo, 2016-06-06 16:09:21]

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4151: case
GL_RGB5_A1:
On 2016/06/06 15:25:46, Corentin Wallez wrote:
> On 2016/06/06 at 12:47:47, Zhenyao Mo wrote:
> > I think these are the only packed formats that goes down the gpu path.
> 
> What is the alternative path?

We pack them into target format in software and then just simple tex{Sub}Image,
so no copyTexImage op.

[Ken Russell (switch to Gerrit), 2016-06-06 23:23:48]

lgtm

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4153: //
component sizes have to match the source color format.
Do you think it would be worth making canUseTexImageCanvasByGPU virtual, and
adding this rule in WebGL2RenderingContextBase's version?

I realize this is intended as a temporary workaround. However, there may be a
general problem with handling these packed formats. We've found that some of
these texture formats are not renderable on OS X. If we also can't do
CopyTexImage2D from an RGBA8 texture to one of these packed formats, then we
have no way to do a GPU-GPU copy into these packed formats.

[Zhenyao Mo, 2016-06-07 00:36:50]

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2040773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4153: //
component sizes have to match the source color format.
On 2016/06/06 23:23:48, Ken Russell wrote:
> Do you think it would be worth making canUseTexImageCanvasByGPU virtual, and
> adding this rule in WebGL2RenderingContextBase's version?
> 
> I realize this is intended as a temporary workaround. However, there may be a
> general problem with handling these packed formats. We've found that some of
> these texture formats are not renderable on OS X. If we also can't do
> CopyTexImage2D from an RGBA8 texture to one of these packed formats, then we
> have no way to do a GPU-GPU copy into these packed formats.

Done.  RGB565 is only not renderable on Mac NVidia, which seems more like a
driver bug to me.

[Zhenyao Mo, 2016-06-07 01:02:12]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-06-07 01:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2040773002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-06-07 01:02:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040773002/20001

[commit-bot: I haz the power, 2016-06-07 05:13:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 05:15:03]

Description was changed from

==========
Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to
match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to
match.

We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.

BUG=429053
TEST=gpu_bots
R=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fbae9a940e3e1086437785e55fc5e773a0245692
Cr-Commit-Position: refs/heads/master@{#398230}
==========

[commit-bot: I haz the power, 2016-06-07 05:15:04]

Patchset 2 (id:??) landed as
https://crrev.com/fbae9a940e3e1086437785e55fc5e773a0245692
Cr-Commit-Position: refs/heads/master@{#398230}