third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 2040773002: Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 2040773002: Upload textures through GPU path to non-8-bit color formats won't work in WebGL2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index f6738b88b58248e6ae101cf6b1e65dac499bdb38..4172d0e8627b3f9c451a1c6094a2efe76442eebb 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -792,7 +792,7 @@ protected:

// Copy from the canvas element directly to the texture via the GPU, without a read-back to system memory.

void texImageCanvasByGPU(TexImageByGPUType, WebGLTexture*, GLenum target, GLint level,

GLint internalformat, GLenum type, GLint xoffset, GLint yoffset, GLint zoffset, HTMLCanvasElement*);

- bool canUseTexImageCanvasByGPU(GLint internalformat, GLenum type);

+ virtual bool canUseTexImageCanvasByGPU(GLint internalformat, GLenum type);

virtual WebGLImageConversion::PixelStoreParams getPackPixelStoreParams();

virtual WebGLImageConversion::PixelStoreParams getUnpackPixelStoreParams(TexImageDimension);

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | no next file » | no next file with comments »