third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h - Issue 2040773002: Upload textures through GPU path to non-8-bit color formats won't work in WebGL2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2040773002: Upload textures through GPU path to non-8-bit color formats won't work in WebGL2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

index 05f34990b621ef4b688365ad63ef979baacbb049..fd978cdac831c8d54ae244007f9fa6044ce41d39 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

@@ -271,6 +271,8 @@ protected:

WebGLBuffer* validateBufferDataTarget(const char* functionName, GLenum target) override;

bool validateBufferDataUsage(const char* functionName, GLenum usage) override;

+ bool canUseTexImageCanvasByGPU(GLint internalformat, GLenum type) override;

void removeBoundBuffer(WebGLBuffer*) override;

void resetUnpackParameters() override;