Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2043063002: DO NOT COMMIT - Unrelated changes made by run-clang-tidy.py (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
etienneb
CC:
chromium-reviews, extensions-reviews_chromium.org, wfh+watch_chromium.org, rickyz+watch_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, fdoray
Base URL:
https://chromium.googlesource.com/chromium/src.git@d_WE998_allwin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT - Unrelated changes made by run-clang-tidy.py -checks=-*,misc-WEvent -fix on Windows BUG=Meh CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M base/numerics/safe_conversions_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler/win32_stack_frame_unwinder_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/browser_action_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_watcher/chrome_watcher_main.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sandbox/win/src/process_mitigations_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/contrib/minizip/unzip.c View 1 chunk +1 line, -1 line 1 comment Download
M third_party/zlib/contrib/minizip/zip.c View 1 chunk +2 lines, -2 lines 1 comment Download
M ui/base/layout.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2039943005 Patch 1

Messages

Total messages: 8 (3 generated)
gab
@etienne FYI: running clang-tidy on Windows "worked" (many errors but still got some changes out ...
4 years, 6 months ago (2016-06-07 16:04:36 UTC) #4
etienneb
some fixes sound wrong!? https://codereview.chromium.org/2043063002/diff/1/third_party/zlib/contrib/minizip/unzip.c File third_party/zlib/contrib/minizip/unzip.c (right): https://codereview.chromium.org/2043063002/diff/1/third_party/zlib/contrib/minizip/unzip.c#newcode1699 third_party/zlib/contrib/minizip/unzip.c:1699: if (pfile_in_zip_read_info->read_buffer = NULL) I ...
4 years, 6 months ago (2016-06-07 16:14:30 UTC) #5
etienneb
some fixes sound wrong!?
4 years, 6 months ago (2016-06-07 16:14:31 UTC) #6
gab
On 2016/06/07 16:14:31, etienneb wrote: > some fixes sound wrong!? No trying to fix this, ...
4 years, 6 months ago (2016-06-07 16:18:09 UTC) #7
gab
4 years, 6 months ago (2016-06-07 19:38:40 UTC) #8
Message was sent while issue was closed. 
On 2016/06/07 16:18:09, gab wrote:
> On 2016/06/07 16:14:31, etienneb wrote:
> > some fixes sound wrong!?
> 
> No trying to fix this, read CL description, this were unepxected automated
> changes made by clang-tidy when running my fix.

This is actually worse than I thought..! It also changed stuff in submodules
(i.e. third_party/ stuff not in main git repo)... so I have to manually go reset
those 1 by 1...

Powered by Google App Engine
This is Rietveld 408576698