Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: components/browser_watcher/window_hang_monitor_win_unittest.cc

Issue 2039943005: clang-tidy WaitableEvent refactor (Windows side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | components/mus/common/gpu_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/window_hang_monitor_win_unittest.cc
diff --git a/components/browser_watcher/window_hang_monitor_win_unittest.cc b/components/browser_watcher/window_hang_monitor_win_unittest.cc
index d1917035e9bbaec861dd6e8a479107567c742b23..a8ce37ad4b1a8c4475f9fce13766654b9fffb491 100644
--- a/components/browser_watcher/window_hang_monitor_win_unittest.cc
+++ b/components/browser_watcher/window_hang_monitor_win_unittest.cc
@@ -96,7 +96,8 @@ class MonitoredProcessClient {
public:
MonitoredProcessClient()
: message_window_thread_("Message window thread"),
- hang_event_(true, false) {
+ hang_event_(base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED) {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
read_pipe_.Set(GetSwitchValueHandle(command_line, kChildReadPipeSwitch));
@@ -143,7 +144,9 @@ class MonitoredProcessClient {
base::Thread::Options(base::MessageLoop::TYPE_UI, 0)));
bool succeeded = false;
- base::WaitableEvent created(true, false);
+ base::WaitableEvent created(
+ base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
ASSERT_TRUE(message_window_thread_.task_runner()->PostTask(
FROM_HERE,
base::Bind(&MonitoredProcessClient::CreateMessageWindowInWorkerThread,
@@ -192,7 +195,9 @@ class MonitoredProcessClient {
}
void DeleteMessageWindow() {
- base::WaitableEvent deleted(true, false);
+ base::WaitableEvent deleted(
+ base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
message_window_thread_.task_runner()->PostTask(
FROM_HERE,
base::Bind(&MonitoredProcessClient::DeleteMessageWindowInWorkerThread,
@@ -238,7 +243,8 @@ class HangMonitorThread {
// Instantiates the background thread.
HangMonitorThread()
: event_(WindowHangMonitor::WINDOW_NOT_FOUND),
- event_received_(false, false),
+ event_received_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED),
thread_("Hang monitor thread") {}
~HangMonitorThread() {
@@ -254,7 +260,9 @@ class HangMonitorThread {
return false;
}
- base::WaitableEvent complete(false, false);
+ base::WaitableEvent complete(
+ base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
if (!thread_.task_runner()->PostTask(
FROM_HERE,
base::Bind(&HangMonitorThread::StartupOnThread,
« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | components/mus/common/gpu_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698