media/capture/video/win/video_capture_device_mf_win.cc - Issue 2039943005: clang-tidy WaitableEvent refactor (Windows side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/win/video_capture_device_mf_win.cc

Issue 2039943005: clang-tidy WaitableEvent refactor (Windows side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/win/video_capture_device_mf_win.cc

diff --git a/media/capture/video/win/video_capture_device_mf_win.cc b/media/capture/video/win/video_capture_device_mf_win.cc

index 17909a89be89c8d32f8941aa7be7ae442bf26e7c..a5e7735ecd8ff3335c4b59465ef829c55de39a25 100644

--- a/media/capture/video/win/video_capture_device_mf_win.cc

+++ b/media/capture/video/win/video_capture_device_mf_win.cc

@@ -273,7 +273,8 @@ void VideoCaptureDeviceMFWin::AllocateAndStart(

void VideoCaptureDeviceMFWin::StopAndDeAllocate() {

DCHECK(CalledOnValidThread());

- base::WaitableEvent flushed(false, false);

+ base::WaitableEvent flushed(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

const int kFlushTimeOutInMs = 1000;

bool wait = false;

{