Add GpuCommandBuffer support.

Add GpuCommandBuffer support.

Currently this is not actually hooked into the system.

To give some context, in a follow up CL I'll add this to GrDrawTarget.
For this I will move the gpu onDraw command to the GpuCommandBuffer as well.
For GL this will end up just being a pass through to a non virtual draw(...)
on GrGLGpu, and for vulkan it will mostly do what it currently does but
adding commands to the secondary command buffer instead.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2038583002

Committed: https://skia.googlesource.com/skia/+/066df7ca911b65d416783f3bec6f4f1662948ad5

[egdaniel, 2016-06-02 15:06:05]

Description was changed from

==========
Add GpuCommandBuffer support.

Currently this is not actually hooked into the system.

To give some context, in a follow up CL I'll add this to GrDrawTarget.
For this I will move the gpu onDraw command to the GpuCommandBuffer as well.
For GL this will end up just being a pass through to a non virtual draw(...)
on GrGLGpu, and for vulkan it will mostly do what it currently does but
adding commands to the secondary command buffer instead.

BUG=skia:
==========

to

==========
Add GpuCommandBuffer support.

Currently this is not actually hooked into the system.

To give some context, in a follow up CL I'll add this to GrDrawTarget.
For this I will move the gpu onDraw command to the GpuCommandBuffer as well.
For GL this will end up just being a pass through to a non virtual draw(...)
on GrGLGpu, and for vulkan it will mostly do what it currently does but
adding commands to the secondary command buffer instead.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2038583002
==========

[egdaniel, 2016-06-02 16:56:20]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com, robertphillips@google.com

[egdaniel, 2016-06-06 20:24:06]

rebased

[jvanverth1, 2016-06-06 20:47:43]

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:316: this->invalidateState();
All of it must be reset? That's unfortunate.

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkResource...
File src/gpu/vk/GrVkResourceProvider.cpp (right):

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkResource...
src/gpu/vk/GrVkResourceProvider.cpp:144:
GrVkResourceProvider::CompatibleRPHandle* pRPHandle = &tempRPHandle;
Probably not much difference in assembly, but I suggest
GrVkResourceProvider::CompatibleRPHandle* pRPHandle = compatibleHandle ?
compatibleHandle : &tempRPHandle;

[egdaniel, 2016-06-07 15:22:37]

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:316: this->invalidateState();
On 2016/06/06 20:47:43, jvanverth1 wrote:
> All of it must be reset? That's unfortunate.

Yes. But in general this shouldn't hurt us because we'll hopefully already
merged draws together there were using the same pipeline, buffers, etc. So in
practice we were going to bind new things anyways.

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkResource...
File src/gpu/vk/GrVkResourceProvider.cpp (right):

https://codereview.chromium.org/2038583002/diff/60001/src/gpu/vk/GrVkResource...
src/gpu/vk/GrVkResourceProvider.cpp:144:
GrVkResourceProvider::CompatibleRPHandle* pRPHandle = &tempRPHandle;
On 2016/06/06 20:47:43, jvanverth1 wrote:
> Probably not much difference in assembly, but I suggest
> GrVkResourceProvider::CompatibleRPHandle* pRPHandle = compatibleHandle ?
> compatibleHandle : &tempRPHandle;

Done.

[jvanverth1, 2016-06-07 15:27:25]

lgtm

[egdaniel, 2016-06-08 19:44:41]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-06-08 19:44:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038583002/80001

[commit-bot: I haz the power, 2016-06-08 19:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 19:46:22]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[egdaniel, 2016-06-08 19:58:39]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-06-08 19:58:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2038583002/#ps100001
(title: "add dtor")

[commit-bot: I haz the power, 2016-06-08 19:58:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038583002/100001

[commit-bot: I haz the power, 2016-06-08 20:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 20:04:25]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[egdaniel, 2016-06-08 20:22:19]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-06-08 20:22:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2038583002/#ps120001
(title: "fix clang")

[commit-bot: I haz the power, 2016-06-08 20:22:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038583002/120001

[commit-bot: I haz the power, 2016-06-08 20:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 20:26:15]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[egdaniel, 2016-06-08 20:35:52]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-06-08 20:35:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2038583002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-06-08 20:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038583002/140001

[commit-bot: I haz the power, 2016-06-08 21:02:29]

Description was changed from

==========
Add GpuCommandBuffer support.

Currently this is not actually hooked into the system.

To give some context, in a follow up CL I'll add this to GrDrawTarget.
For this I will move the gpu onDraw command to the GpuCommandBuffer as well.
For GL this will end up just being a pass through to a non virtual draw(...)
on GrGLGpu, and for vulkan it will mostly do what it currently does but
adding commands to the secondary command buffer instead.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2038583002
==========

to

==========
Add GpuCommandBuffer support.

Currently this is not actually hooked into the system.

To give some context, in a follow up CL I'll add this to GrDrawTarget.
For this I will move the gpu onDraw command to the GpuCommandBuffer as well.
For GL this will end up just being a pass through to a non virtual draw(...)
on GrGLGpu, and for vulkan it will mostly do what it currently does but
adding commands to the secondary command buffer instead.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2038583002

Committed:
https://skia.googlesource.com/skia/+/066df7ca911b65d416783f3bec6f4f1662948ad5
==========

[commit-bot: I haz the power, 2016-06-08 21:02:31]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/066df7ca911b65d416783f3bec6f4f1662948ad5