Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Issue 2036943002: Reduced the callers to the non-const version of CSSValueList::item() (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_take_const_ref
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduced the callers to the non-const version of CSSValueList::item() Reduced the callers to the non-const version of CSSValueList::item(). All non-trivial callsites were changed to use the const version of the item() method. This is pre-work to remove the non-const version altogether. Remaining callsites either require CSSValueList::append() to take a const pointer (which would require CSSValueList to actually store Member<const CSSValue>s), or require some other cascading const change. NOTE: This patch also involved making CSSFontFaceSrcValue::fetch() a const method, and making the cached member m_fetched mutable. BUG=526586 Committed: https://crrev.com/4c39bbe8d34bb44f9f1b484e3c98a0c1b4ae5f6c Cr-Commit-Position: refs/heads/master@{#397979}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
sashab
4 years, 6 months ago (2016-06-03 04:59:07 UTC) #2
Timothy Loh
lgtm
4 years, 6 months ago (2016-06-03 05:35:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036943002/20001
4 years, 6 months ago (2016-06-06 05:36:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 05:40:37 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 05:41:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c39bbe8d34bb44f9f1b484e3c98a0c1b4ae5f6c
Cr-Commit-Position: refs/heads/master@{#397979}

Powered by Google App Engine
This is Rietveld 408576698