Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2038443003: Made ElementStyleResources store const CSSSVGDocumentValues (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@+delete_nonconst_cssvaluelist_item_function
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made ElementStyleResources store const CSSSVGDocumentValues Made ElementStyleResources store const CSSSVGDocumentValues in m_pendingSVGDocuments, meaning that addPendingSVGDocument() can take a const CSSSVGDocumentValue* instead of a regular pointer. This was required so that FilterOperationResolver::createFilterOperations() can use the non-const call to CSSValueList::item(). This also involved making CSSSVGDocumentValue::load() a const method and marking CSSSVGDocumentValue's cache-related members as mutable. BUG=526586 Committed: https://crrev.com/a04d68383de9cc5e71706c4f227b4c67ca4b433d Cr-Commit-Position: refs/heads/master@{#397985}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSVGDocumentValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
sashab
4 years, 6 months ago (2016-06-03 06:02:33 UTC) #2
Timothy Loh
seems fine, lgtm
4 years, 6 months ago (2016-06-03 06:12:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038443003/20001
4 years, 6 months ago (2016-06-06 05:42:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 06:32:42 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 06:34:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a04d68383de9cc5e71706c4f227b4c67ca4b433d
Cr-Commit-Position: refs/heads/master@{#397985}

Powered by Google App Engine
This is Rietveld 408576698