Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issue 2033583006: Change CSSValueList::removeAll and hasValue to take const CSSValue& (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change CSSValueList::removeAll and hasValue to take const CSSValue& Change CSSValueList::removeAll and CSSValueList::hasValue to take const references instead of pointers. This is more semantically correct and safe, and is good pre-work for making CSSValueList::item() return const references. BUG=526586 Committed: https://crrev.com/d87f984cb32b4a55b95232b9c359269694cf8614 Cr-Commit-Position: refs/heads/master@{#397977}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/CSSValueList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
sashab
4 years, 6 months ago (2016-06-03 04:39:59 UTC) #2
Timothy Loh
On 2016/06/03 04:39:59, sashab wrote: lgtm
4 years, 6 months ago (2016-06-03 04:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033583006/1
4 years, 6 months ago (2016-06-03 04:59:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033583006/1
4 years, 6 months ago (2016-06-06 01:00:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033583006/20001
4 years, 6 months ago (2016-06-06 04:45:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 05:35:05 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 05:36:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d87f984cb32b4a55b95232b9c359269694cf8614
Cr-Commit-Position: refs/heads/master@{#397977}

Powered by Google App Engine
This is Rietveld 408576698