third_party/WebKit/Source/core/css/FontFace.cpp - Issue 2036943002: Reduced the callers to the non-const version of CSSValueList::item()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFace.cpp

Issue 2036943002: Reduced the callers to the non-const version of CSSValueList::item() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_take_const_ref

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSValueList.h ('k') | third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/FontFace.cpp

diff --git a/third_party/WebKit/Source/core/css/FontFace.cpp b/third_party/WebKit/Source/core/css/FontFace.cpp

index f88cbfd9f3feb2e7a7d3e789352f7b40f4a1296f..12acfba0f8079e65c81ff682a86edb71f50148a6 100644

--- a/third_party/WebKit/Source/core/css/FontFace.cpp

+++ b/third_party/WebKit/Source/core/css/FontFace.cpp

@@ -537,7 +537,7 @@ static CSSFontFace* createCSSFontFace(FontFace* fontFace, CSSValue* unicodeRange

if (CSSValueList* rangeList = toCSSValueList(unicodeRange)) {

unsigned numRanges = rangeList->length();

for (unsigned i = 0; i < numRanges; i++) {

- CSSUnicodeRangeValue* range = toCSSUnicodeRangeValue(rangeList->item(i));

+ const CSSUnicodeRangeValue* range = toCSSUnicodeRangeValue(rangeList->item(i));

ranges.append(UnicodeRange(range->from(), range->to()));

}

@@ -559,7 +559,7 @@ void FontFace::initCSSFontFace(Document* document, CSSValue* src)

for (int i = 0; i < srcLength; i++) {

// An item in the list either specifies a string (local font name) or a URL (remote font to download).

- CSSFontFaceSrcValue* item = toCSSFontFaceSrcValue(srcList->item(i));

+ const CSSFontFaceSrcValue* item = toCSSFontFaceSrcValue(srcList->item(i));

CSSFontFaceSource* source = nullptr;

if (!item->isLocal()) {