third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp - Issue 2036943002: Reduced the callers to the non-const version of CSSValueList::item()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

Issue 2036943002: Reduced the callers to the non-const version of CSSValueList::item() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluelist_take_const_ref

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/FontFace.cpp ('k') | third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

index 5cbe787152950b2989efa437b4b7e467e9906351..e1e671a0da9c6391da0d09211113c100f9c6f984 100644

--- a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -149,7 +149,7 @@ FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt

continue;

}

- CSSPrimitiveValue* firstValue = filterValue->length() && filterValue->item(0)->isPrimitiveValue() ? toCSSPrimitiveValue(filterValue->item(0)) : nullptr;

+ const CSSPrimitiveValue* firstValue = filterValue->length() && filterValue->item(0)->isPrimitiveValue() ? toCSSPrimitiveValue(filterValue->item(0)) : nullptr;

switch (filterValue->functionType()) {

case CSSValueGrayscale:

case CSSValueSepia:

@@ -194,7 +194,7 @@ FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt

break;

}

case CSSValueDropShadow: {

- CSSShadowValue* item = toCSSShadowValue(filterValue->item(0));

+ const CSSShadowValue* item = toCSSShadowValue(filterValue->item(0));

IntPoint location(item->x->computeLength<int>(conversionData), item->y->computeLength<int>(conversionData));

int blur = item->blur ? item->blur->computeLength<int>(conversionData) : 0;

Color shadowColor = Color::black;