third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp - Issue 2035373002: Made StylePropertySet::getPropertyCSSValue return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

Issue 2035373002: Made StylePropertySet::getPropertyCSSValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_fix_cssparser_font_face_descriptor_to_return_const

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

index c33e1f6801b0ad1b69403e4100ee16f6d653d9b0..3f248994d466458ee3368f57787a1095980c3979 100644

--- a/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

@@ -146,11 +146,11 @@ float ViewportStyleResolver::viewportArgumentValue(CSSPropertyID id) const

if (id == CSSPropertyUserZoom)

defaultValue = 1;

- CSSValue* value = m_propertySet->getPropertyCSSValue(id);

+ const CSSValue* value = m_propertySet->getPropertyCSSValue(id);

if (!value || !value->isPrimitiveValue())

return defaultValue;

- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

+ const CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

if (primitiveValue->isNumber() || primitiveValue->isPx())

return primitiveValue->getFloatValue();

@@ -196,11 +196,11 @@ Length ViewportStyleResolver::viewportLengthValue(CSSPropertyID id) const

|| id == CSSPropertyMaxWidth

|| id == CSSPropertyMinWidth);

- CSSValue* value = m_propertySet->getPropertyCSSValue(id);

+ const CSSValue* value = m_propertySet->getPropertyCSSValue(id);

if (!value || !value->isPrimitiveValue())

return Length(); // auto

- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

+ const CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

if (primitiveValue->getValueID() == CSSValueInternalExtendToZoom)

return Length(ExtendToZoom);