third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp - Issue 2035373002: Made StylePropertySet::getPropertyCSSValue return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

Issue 2035373002: Made StylePropertySet::getPropertyCSSValue return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_fix_cssparser_font_face_descriptor_to_return_const

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

index b88584ac69d9298d4b21ba3daa3aa9bc9f2c172f..2eaea703d3225e657af975761297db42602cad3a 100644

--- a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

@@ -147,7 +147,7 @@ static EColorInterpolation colorInterpolationForElement(SVGElement& element, ECo

// No layout has been performed, try to determine the property value

// "manually" (used by external SVG files.)

if (const StylePropertySet* propertySet = element.presentationAttributeStyle()) {

- CSSValue* cssValue = propertySet->getPropertyCSSValue(CSSPropertyColorInterpolationFilters);

+ const CSSValue* cssValue = propertySet->getPropertyCSSValue(CSSPropertyColorInterpolationFilters);

if (cssValue && cssValue->isPrimitiveValue()) {

const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(*cssValue);

return primitiveValue.convertTo<EColorInterpolation>();

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp ('k') | no next file » | no next file with comments »