base/task_scheduler/task_scheduler_impl_unittest.cc - Issue 2032603002: Migrate WaitableEvent to enum-based constructor in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/task_scheduler_impl_unittest.cc

Issue 2032603002: Migrate WaitableEvent to enum-based constructor in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: undo incorrect template change Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/task_scheduler/task_scheduler_impl_unittest.cc

diff --git a/base/task_scheduler/task_scheduler_impl_unittest.cc b/base/task_scheduler/task_scheduler_impl_unittest.cc

index c491a4a13450b6edb31c8b233ed99ab16f1e5c0f..50e0caeb1c7059f467376c2ac7311a3eb01e841f 100644

--- a/base/task_scheduler/task_scheduler_impl_unittest.cc

+++ b/base/task_scheduler/task_scheduler_impl_unittest.cc

@@ -158,7 +158,8 @@ std::vector<TraitsExecutionModePair> GetTraitsExecutionModePairs() {

// TaskTraits runs on a thread with the expected priority and I/O restrictions.

// The ExecutionMode parameter is ignored by this test.

TEST_P(TaskSchedulerImplTest, PostTaskWithTraits) {

- WaitableEvent task_ran(true, false);

+ WaitableEvent task_ran(WaitableEvent::ResetPolicy::MANUAL,

+ WaitableEvent::InitialState::NOT_SIGNALED);

scheduler_->PostTaskWithTraits(

FROM_HERE, GetParam().traits,

Bind(&VerifyTaskEnvironementAndSignalEvent, GetParam().traits,

« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | base/task_scheduler/task_tracker_unittest.cc » ('j') | no next file with comments »