base/test/trace_event_analyzer_unittest.cc - Issue 2032603002: Migrate WaitableEvent to enum-based constructor in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_event_analyzer_unittest.cc

Issue 2032603002: Migrate WaitableEvent to enum-based constructor in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: undo incorrect template change Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/test/trace_event_analyzer_unittest.cc

diff --git a/base/test/trace_event_analyzer_unittest.cc b/base/test/trace_event_analyzer_unittest.cc

index e73dd65b069ac09da2d66c1cf1fb49f871890fc2..086cfc97d343bef7ab979a92e054f91e890c943a 100644

--- a/base/test/trace_event_analyzer_unittest.cc

+++ b/base/test/trace_event_analyzer_unittest.cc

@@ -60,7 +60,9 @@ void TraceEventAnalyzerTest::BeginTracing() {

void TraceEventAnalyzerTest::EndTracing() {

base::trace_event::TraceLog::GetInstance()->SetDisabled();

- base::WaitableEvent flush_complete_event(false, false);

+ base::WaitableEvent flush_complete_event(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

base::trace_event::TraceLog::GetInstance()->Flush(

base::Bind(&TraceEventAnalyzerTest::OnTraceDataCollected,

base::Unretained(this),

« no previous file with comments | « base/test/thread_test_helper.cc ('k') | base/threading/platform_thread_unittest.cc » ('j') | no next file with comments »