base/task_scheduler/scheduler_thread_pool_impl.cc - Issue 2032603002: Migrate WaitableEvent to enum-based constructor in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_thread_pool_impl.cc

Issue 2032603002: Migrate WaitableEvent to enum-based constructor in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: undo incorrect template change Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/task_scheduler/scheduler_service_thread_unittest.cc ('k') | base/task_scheduler/scheduler_thread_pool_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/task_scheduler/scheduler_thread_pool_impl.cc

diff --git a/base/task_scheduler/scheduler_thread_pool_impl.cc b/base/task_scheduler/scheduler_thread_pool_impl.cc

index 3433ce6dd3bf03cf794b2ee29b9ffa04c7c99d6c..c7e339a0dd68855a238f7260358449dc75571b28 100644

--- a/base/task_scheduler/scheduler_thread_pool_impl.cc

+++ b/base/task_scheduler/scheduler_thread_pool_impl.cc

@@ -495,9 +495,11 @@ SchedulerThreadPoolImpl::SchedulerThreadPoolImpl(

idle_worker_threads_stack_lock_(shared_priority_queue_.container_lock()),

idle_worker_threads_stack_cv_for_testing_(

idle_worker_threads_stack_lock_.CreateConditionVariable()),

- join_for_testing_returned_(true, false),

+ join_for_testing_returned_(WaitableEvent::ResetPolicy::MANUAL,

+ WaitableEvent::InitialState::NOT_SIGNALED),

#if DCHECK_IS_ON()

- threads_created_(true, false),

+ threads_created_(WaitableEvent::ResetPolicy::MANUAL,

+ WaitableEvent::InitialState::NOT_SIGNALED),

#endif

task_tracker_(task_tracker),

delayed_task_manager_(delayed_task_manager) {