Issue 2028603004: Rename 'items' into 'displayItems' in PaymentDetails.

Issue 2028603004: Rename 'items' into 'displayItems' in PaymentDetails. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead

Modified:
4 years, 6 months ago

Reviewers:
Tom Sepez, Marijn Kruisselbrink, gone

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, haraken, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, palmer

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename 'items' into 'displayItems' in PaymentDetails. This patch renames PaymentDetails.items into PaymentDetails.displayItems to follow the spec updates. This patch does not introduce 100% compliance with the spec. It is a simple search-and-replace patch. https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f BUG=587995 Committed: https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d Cr-Commit-Position: refs/heads/master@{#397576}

Patch Set 1 : #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -45 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java	View	6 chunks	+21 lines, -15 lines	0 comments	Download
M	chrome/test/data/android/payments/dynamic_shipping.js	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/data/android/payments/free_shipping.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/android/payments/no_shipping.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/payments/payment-request-interface.html	View	4 chunks	+7 lines, -5 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/payments/PaymentDetails.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/payments/PaymentRequest.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp	View	9 chunks	+11 lines, -11 lines	0 comments	Download
M	third_party/WebKit/public/platform/modules/payments/payment_request.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 16 (8 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

please use gerrit instead

mek@, ptal WebKit. dfalcantara@, ptal Java. palmer@, ptal payment_request.mojom.

4 years, 6 months ago (2016-06-01 18:40:25 UTC) #3

please use gerrit instead

+tsepez@, ptal payment_request.mojom. -palmer@, who is ooo.

4 years, 6 months ago (2016-06-02 19:45:29 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028603004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028603004/20001

4 years, 6 months ago (2016-06-02 22:19:21 UTC) #12

commit-bot: I haz the power

4 years, 6 months ago (2016-06-03 02:26:08 UTC) #16

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c11d1de471dea33c3aa3242e59bc2bb03eb42b6d
Cr-Commit-Position: refs/heads/master@{#397576}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages