Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids.

Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of
resource ids for the file is reduced from 500 to 200.

TextInputClient methods IsEditCommandEnabled and SetEditCommandForNextKeyEvent
are renamed to IsTextEditCommandEnabled and SetTextEditCommandForNextKeyEvent
respectively. Textfield::ExecuteEditCommand is renamed to
Textfield::ExecuteTextEditCommand.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to
replace resource ids with a ui::TextEditCommand enum for text editing commands
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
Committed: https://crrev.com/9f4772321729e25fa0ce1fe4248228be52bd28d3
Cr-Commit-Position: refs/heads/master@{#400921}

[karandeepb, 2016-06-06 04:02:03]

Description was changed from

==========
Refactor5: Modify ui::TextInputClient to use ui::TextEditCommand.
==========

to

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

This is second in series of CLs to replace resource ids with a
ui::TextEditCommand enum for text editing commands in views::Textfield.

BUG=586985
==========

[karandeepb, 2016-06-06 07:02:28]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-06-06 07:02:38]

Patchset #1 (id:20001) has been deleted

[karandeepb, 2016-06-06 07:02:50]

Patchset #1 (id:40001) has been deleted

[karandeepb, 2016-06-06 07:02:59]

Patchset #1 (id:60001) has been deleted

[karandeepb, 2016-06-06 07:03:12]

Patchset #1 (id:80001) has been deleted

[karandeepb, 2016-06-06 07:03:26]

Patchset #1 (id:100001) has been deleted

[tapted, 2016-06-06 07:48:01]

tapted@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2016-06-06 07:48:02]

https://codereview.chromium.org/2027133002/diff/120001/ui/base/ime/text_input...
File ui/base/ime/text_input_client.h (right):

https://codereview.chromium.org/2027133002/diff/120001/ui/base/ime/text_input...
ui/base/ime/text_input_client.h:17: #include "ui/events/text_edit_commands.h"
nit: forward declare

https://codereview.chromium.org/2027133002/diff/120001/ui/events/text_edit_co...
File ui/events/text_edit_commands.h (right):

https://codereview.chromium.org/2027133002/diff/120001/ui/events/text_edit_co...
ui/events/text_edit_commands.h:10: enum class TextEditCommand {
nit: needs a comment

https://codereview.chromium.org/2027133002/diff/120001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2027133002/diff/120001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:1571: return false;
NOTREACHED() before this?

[karandeepb, 2016-06-08 03:07:41]

Patchset #3 (id:160001) has been deleted

[karandeepb, 2016-06-08 03:07:51]

Patchset #3 (id:180001) has been deleted

[karandeepb, 2016-06-08 03:11:58]

PTAL Thanks.

https://codereview.chromium.org/2027133002/diff/120001/ui/base/ime/text_input...
File ui/base/ime/text_input_client.h (right):

https://codereview.chromium.org/2027133002/diff/120001/ui/base/ime/text_input...
ui/base/ime/text_input_client.h:17: #include "ui/events/text_edit_commands.h"
On 2016/06/06 07:48:02, tapted wrote:
> nit: forward declare

Done.

https://codereview.chromium.org/2027133002/diff/120001/ui/events/text_edit_co...
File ui/events/text_edit_commands.h (right):

https://codereview.chromium.org/2027133002/diff/120001/ui/events/text_edit_co...
ui/events/text_edit_commands.h:10: enum class TextEditCommand {
On 2016/06/06 07:48:02, tapted wrote:
> nit: needs a comment

Done.

https://codereview.chromium.org/2027133002/diff/120001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2027133002/diff/120001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:1571: return false;
On 2016/06/06 07:48:02, tapted wrote:
> NOTREACHED() before this?

Done.

[karandeepb, 2016-06-09 07:28:51]

Patchset #5 (id:240001) has been deleted

[karandeepb, 2016-06-09 07:29:04]

Patchset #5 (id:260001) has been deleted

[karandeepb, 2016-06-09 07:43:44]

Patchset #5 (id:280001) has been deleted

[karandeepb, 2016-06-09 10:53:53]

PTAL msw@. Thanks.

[karandeepb, 2016-06-09 10:54:13]

karandeepb@chromium.org changed reviewers:
+ msw@chromium.org

[karandeepb, 2016-06-09 10:54:14]

PTAL msw@. Thanks.

[karandeepb, 2016-06-09 11:03:11]

Description was changed from

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

This is second in series of CLs to replace resource ids with a
ui::TextEditCommand enum for text editing commands in views::Textfield.

BUG=586985
==========

to

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

This is second in series of CLs to replace resource ids with a
ui::TextEditCommand enum for text editing commands in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

[msw, 2016-06-10 00:48:51]

https://codereview.chromium.org/2027133002/diff/320001/ui/events/text_edit_co...
File ui/events/text_edit_commands.h (right):

https://codereview.chromium.org/2027133002/diff/320001/ui/events/text_edit_co...
ui/events/text_edit_commands.h:5: #ifndef UI_EVENTS_TEXT_EDITING_COMMANDS_H_
Move this to ui/base/ime, ui/base/text, or ui/base, it's hardly event-related.

https://codereview.chromium.org/2027133002/diff/320001/ui/strings/ui_strings.grd
File ui/strings/ui_strings.grd (left):

https://codereview.chromium.org/2027133002/diff/320001/ui/strings/ui_strings....
ui/strings/ui_strings.grd:392: <!-- Textfield editing commands; their actual
string contents are unused. -->
tools/gritsettings/resource_ids reserves 500 ids for this file, can you reduce
it to 200? (it'll actually use ~130 after you remove these)

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:128: if (!shift)
nit: add curly braces.

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:273: // Returns ui::TextEditCommand
corresponding to |command_id| menu action. Keep
nit: "returns the", "to the"

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:1577: DCHECK(scheduled_edit_command_ ==
ui::TextEditCommand::INVALID_COMMAND);
nit: why not DCHECK_EQ?

[karandeepb, 2016-06-10 07:27:24]

Patchset #7 (id:340001) has been deleted

[karandeepb, 2016-06-10 08:20:47]

PTAL msw@. Thanks.

https://codereview.chromium.org/2027133002/diff/320001/ui/events/text_edit_co...
File ui/events/text_edit_commands.h (right):

https://codereview.chromium.org/2027133002/diff/320001/ui/events/text_edit_co...
ui/events/text_edit_commands.h:5: #ifndef UI_EVENTS_TEXT_EDITING_COMMANDS_H_
On 2016/06/10 00:48:51, msw wrote:
> Move this to ui/base/ime, ui/base/text, or ui/base, it's hardly event-related.

Moved to ui/base/ime.

https://codereview.chromium.org/2027133002/diff/320001/ui/strings/ui_strings.grd
File ui/strings/ui_strings.grd (left):

https://codereview.chromium.org/2027133002/diff/320001/ui/strings/ui_strings....
ui/strings/ui_strings.grd:392: <!-- Textfield editing commands; their actual
string contents are unused. -->
On 2016/06/10 00:48:51, msw wrote:
> tools/gritsettings/resource_ids reserves 500 ids for this file, can you reduce
> it to 200? (it'll actually use ~130 after you remove these)

Done.

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:128: if (!shift)
On 2016/06/10 00:48:51, msw wrote:
> nit: add curly braces.

Done.

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:273: // Returns ui::TextEditCommand
corresponding to |command_id| menu action. Keep
On 2016/06/10 00:48:51, msw wrote:
> nit: "returns the", "to the"

Done.

https://codereview.chromium.org/2027133002/diff/320001/ui/views/controls/text...
ui/views/controls/textfield/textfield.cc:1577: DCHECK(scheduled_edit_command_ ==
ui::TextEditCommand::INVALID_COMMAND);
On 2016/06/10 00:48:51, msw wrote:
> nit: why not DCHECK_EQ?

Done. I maybe wrong but I think this was giving a compiler error earlier.

[karandeepb, 2016-06-10 08:46:15]

Description was changed from

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

This is second in series of CLs to replace resource ids with a
ui::TextEditCommand enum for text editing commands in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

to

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

This is second in series of CLs to replace resource ids with a
ui::TextEditCommand enum for text editing commands in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

[karandeepb, 2016-06-10 09:22:27]

So, ui/base/ime depends on ui/base which depends on ui/events. 
ui/events contains text_edit_command_aura_linux.cc which needs TextEditCommand
enum. So placing text_edit_commands.h in ui/base/ime or ui/base will cause a
cyclic dependency.

[msw, 2016-06-10 16:36:03]

On 2016/06/10 09:22:27, karandeepb wrote:
> So, ui/base/ime depends on ui/base which depends on ui/events. 
> ui/events contains text_edit_command_aura_linux.cc which needs TextEditCommand
> enum. So placing text_edit_commands.h in ui/base/ime or ui/base will cause a
> cyclic dependency.

I suggest also moving all four ui/events/linux/ files to ui/base/ime, all these
files seem more related to text input than events. Otherwise, leave the new text
editing commands enum in ui/base/events is fine (just odd). Sadrul and Elliot,
do you have any thoughts on that? See my original comment here:
https://codereview.chromium.org/2027133002/diff/320001/ui/events/text_edit_co...

[Elliot Glaysher, 2016-06-10 19:12:34]

On 2016/06/10 16:36:03, msw wrote:
> On 2016/06/10 09:22:27, karandeepb wrote:
> > So, ui/base/ime depends on ui/base which depends on ui/events. 
> > ui/events contains text_edit_command_aura_linux.cc which needs
TextEditCommand
> > enum. So placing text_edit_commands.h in ui/base/ime or ui/base will cause a
> > cyclic dependency.
> 
> I suggest also moving all four ui/events/linux/ files to ui/base/ime, all
these
> files seem more related to text input than events. Otherwise, leave the new
text
> editing commands enum in ui/base/events is fine (just odd). Sadrul and Elliot,
> do you have any thoughts on that? See my original comment here:
>
https://codereview.chromium.org/2027133002/diff/320001/ui/events/text_edit_co...

I don't really have much to say here. It should be possible to move the various
//ui/events/linux/ code to //ui/base/ime/, as libgtk2ui already depends on
//ui/base/ime/.

I would say that it is unfortunate that there's now duplication between
ui::TextEditCommandAuraLinux and ui::TextEditCommand, and that it would be nice
to unify them.

[msw, 2016-06-10 19:27:26]

On 2016/06/10 19:12:34, Elliot Glaysher wrote:
> I would say that it is unfortunate that there's now duplication between
> ui::TextEditCommandAuraLinux and ui::TextEditCommand, and that it would be
nice
> to unify them.

That's done in a later CL in this set:
https://codereview.chromium.org/2034623002

[karandeepb, 2016-06-15 06:21:59]

On 2016/06/10 16:36:03, msw wrote:
> On 2016/06/10 09:22:27, karandeepb wrote:
> > So, ui/base/ime depends on ui/base which depends on ui/events. 
> > ui/events contains text_edit_command_aura_linux.cc which needs
TextEditCommand
> > enum. So placing text_edit_commands.h in ui/base/ime or ui/base will cause a
> > cyclic dependency.
> 
> I suggest also moving all four ui/events/linux/ files to ui/base/ime, all
these
> files seem more related to text input than events. Otherwise, leave the new
text
> editing commands enum in ui/base/events is fine (just odd). Sadrul and Elliot,
> do you have any thoughts on that? See my original comment here:
>
https://codereview.chromium.org/2027133002/diff/320001/ui/events/text_edit_co...

PTAL msw@. Have moved the files in ui/events/linux/* to ui/base/ime/linux/ in a
follow-up - http://crrev.com/2064053002

[karandeepb, 2016-06-15 07:07:56]

Description was changed from

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

This is second in series of CLs to replace resource ids with a
ui::TextEditCommand enum for text editing commands in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

to

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to 
replace resource ids with a ui::TextEditCommand enum for text editing commands 
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

[msw, 2016-06-15 17:11:21]

lgtm, thanks!

[karandeepb, 2016-06-15 23:55:41]

karandeepb@chromium.org changed reviewers:
+ flackr@chromium.org, jochen@chromium.org, sky@chromium.org

[karandeepb, 2016-06-15 23:55:42]

+sky for ui/base/ and ui/views/controls/prefix_selector.* review.
+flackr for tools/gritsettings/resource_ids review.
+jochen for components/ and content/ review.

[flackr, 2016-06-16 08:23:09]

tools/gritsettings/resource_ids lgtm

[sky, 2016-06-16 17:00:37]

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/pref...
File ui/views/controls/prefix_selector.h (right):

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/pref...
ui/views/controls/prefix_selector.h:58: bool
IsEditCommandEnabled(ui::TextEditCommand command) const override;
Can you rename these? IsTextEditCommandEnabled and
SetTextEditCommandForNextKeyEvent.

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/text...
ui/views/controls/textfield/textfield.h:322: virtual void
ExecuteEditCommand(ui::TextEditCommand command);
ExecuteTextEditCommand?

[karandeepb, 2016-06-17 01:33:57]

Description was changed from

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to 
replace resource ids with a ui::TextEditCommand enum for text editing commands 
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

to

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

TextInputClient methods IsEditCommandEnabled and SetEditCommandForNextKeyEvent 
are renamed to IsTextEditCommandEnabled and SetTextEditCommandForNextKeyEvent 
respectively. Textfield::ExecuteEditCommand is renamed to
Textfield::ExecuteTextEditCommand.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to 
replace resource ids with a ui::TextEditCommand enum for text editing commands 
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

[karandeepb, 2016-06-17 02:35:22]

Patchset #9 (id:400001) has been deleted

[karandeepb, 2016-06-17 02:39:03]

PTAL sky@. Thanks.

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/pref...
File ui/views/controls/prefix_selector.h (right):

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/pref...
ui/views/controls/prefix_selector.h:58: bool
IsEditCommandEnabled(ui::TextEditCommand command) const override;
On 2016/06/16 17:00:37, sky wrote:
> Can you rename these? IsTextEditCommandEnabled and
> SetTextEditCommandForNextKeyEvent.

Done.

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/text...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/2027133002/diff/380001/ui/views/controls/text...
ui/views/controls/textfield/textfield.h:322: virtual void
ExecuteEditCommand(ui::TextEditCommand command);
On 2016/06/16 17:00:37, sky wrote:
> ExecuteTextEditCommand?

Done.

[sky, 2016-06-17 15:03:03]

LGTM

[karandeepb, 2016-06-20 00:06:28]

ping jochen@ for components/ and content/ review.

[jochen (gone - plz use gerrit), 2016-06-20 11:34:49]

lgtm

[karandeepb, 2016-06-21 06:36:25]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-06-21 06:36:25]

The patchset sent to the CQ was uploaded after l-g-t-m from flackr@chromium.org,
msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2027133002/#ps420001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-06-21 06:36:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027133002/420001

[commit-bot: I haz the power, 2016-06-21 07:40:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 07:40:30]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[karandeepb, 2016-06-21 07:42:54]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-06-21 07:43:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027133002/420001

[commit-bot: I haz the power, 2016-06-21 08:32:51]

Description was changed from

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

TextInputClient methods IsEditCommandEnabled and SetEditCommandForNextKeyEvent 
are renamed to IsTextEditCommandEnabled and SetTextEditCommandForNextKeyEvent 
respectively. Textfield::ExecuteEditCommand is renamed to
Textfield::ExecuteTextEditCommand.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to 
replace resource ids with a ui::TextEditCommand enum for text editing commands 
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

to

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

TextInputClient methods IsEditCommandEnabled and SetEditCommandForNextKeyEvent 
are renamed to IsTextEditCommandEnabled and SetTextEditCommandForNextKeyEvent 
respectively. Textfield::ExecuteEditCommand is renamed to
Textfield::ExecuteTextEditCommand.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to 
replace resource ids with a ui::TextEditCommand enum for text editing commands 
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

[commit-bot: I haz the power, 2016-06-21 08:32:55]

Committed patchset #9 (id:420001)

[commit-bot: I haz the power, 2016-06-21 08:34:43]

Description was changed from

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of 
resource ids for the file is reduced from 500 to 200.

TextInputClient methods IsEditCommandEnabled and SetEditCommandForNextKeyEvent 
are renamed to IsTextEditCommandEnabled and SetTextEditCommandForNextKeyEvent 
respectively. Textfield::ExecuteEditCommand is renamed to
Textfield::ExecuteTextEditCommand.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to 
replace resource ids with a ui::TextEditCommand enum for text editing commands 
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985
==========

to

==========
Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource
ids.

Currently Views::Textfield represent text editing commands using resource ids,
even though these do not appear anywhere in the UI. This CL adds a new
ui::TextEditCommand enum for use by ui::TextInputClient.

Unused resource ids are removed from ui_strings.grd and the allocation of
resource ids for the file is reduced from 500 to 200.

TextInputClient methods IsEditCommandEnabled and SetEditCommandForNextKeyEvent
are renamed to IsTextEditCommandEnabled and SetTextEditCommandForNextKeyEvent
respectively. Textfield::ExecuteEditCommand is renamed to
Textfield::ExecuteTextEditCommand.

This is a follow-up to crrev.com/2031433002 and is second in series of CLs to
replace resource ids with a ui::TextEditCommand enum for text editing commands
in views::Textfield.

Link to complete patch - http://crrev.com/2029733003

BUG=586985

Committed: https://crrev.com/9f4772321729e25fa0ce1fe4248228be52bd28d3
Cr-Commit-Position: refs/heads/master@{#400921}
==========

[commit-bot: I haz the power, 2016-06-21 08:34:46]

Patchset 9 (id:??) landed as
https://crrev.com/9f4772321729e25fa0ce1fe4248228be52bd28d3
Cr-Commit-Position: refs/heads/master@{#400921}