Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2031913002:
Remove ui::TextEditCommand::DELETE_SELECTION. (Closed)
|
Created:
4 years, 6 months ago by karandeepb Modified:
4 years, 6 months ago CC:
chromium-reviews, yusukes+watch_chromium.org, tdresser+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor5_text_input_client_api Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ui::TextEditCommand::DELETE_SELECTION.
This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is
reduntant since it performs the same operation as a DELETE_FORWARD command.
This is a follow-up to crrev.com/2027133002 and is third in series of CLs to
replace resource ids with a ui::TextEditCommand enum for text editing commands
in views::Textfield.
Link to complete patch - http://crrev.com/2029733003
BUG=586985
Committed: https://crrev.com/5256f1758d0980feaa9593adc42604ee34c6d332
Cr-Commit-Position: refs/heads/master@{#400936}
Patch Set 1 : #Patch Set 2 : #Patch Set 3 : Rebase. #Patch Set 4 : Rebase. #Patch Set 5 : Rebase. #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 31 (24 generated)
Description was changed from ========== Refactor6: Remove ui::TextEditCommand::DELETE ========== to ========== Remove ui::TextEditCommand::DELETE. This CL removes ui::TextEditCommand::DELETE enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. BUG=586985 ==========
Description was changed from ========== Remove ui::TextEditCommand::DELETE. This CL removes ui::TextEditCommand::DELETE enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. BUG=586985 ========== to ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. BUG=586985 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Patchset #1 (id:120001) has been deleted
Patchset #2 (id:160001) has been deleted
Patchset #1 (id:140001) has been deleted
Patchset #1 (id:180001) has been deleted
Patchset #1 (id:200001) has been deleted
Patchset #1 (id:220001) has been deleted
Patchset #1 (id:240001) has been deleted
Patchset #1 (id:260001) has been deleted
karandeepb@chromium.org changed reviewers: + msw@chromium.org
PTAL msw@.
Description was changed from ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. BUG=586985 ========== to ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 ==========
lgtm
Description was changed from ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 ========== to ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is a follow-up to crrev.com/2027133002 and is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 ==========
karandeepb@chromium.org changed reviewers: + sky@chromium.org
+sky for ui/base review.
LGTM
The CQ bit was checked by karandeepb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2031913002/#ps360001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031913002/360001
Message was sent while issue was closed.
Description was changed from ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is a follow-up to crrev.com/2027133002 and is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 ========== to ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is a follow-up to crrev.com/2027133002 and is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:360001)
Message was sent while issue was closed.
Description was changed from ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is a follow-up to crrev.com/2027133002 and is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 ========== to ========== Remove ui::TextEditCommand::DELETE_SELECTION. This CL removes ui::TextEditCommand::DELETE_SELECTION enum value. It is reduntant since it performs the same operation as a DELETE_FORWARD command. This is a follow-up to crrev.com/2027133002 and is third in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 Committed: https://crrev.com/5256f1758d0980feaa9593adc42604ee34c6d332 Cr-Commit-Position: refs/heads/master@{#400936} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/5256f1758d0980feaa9593adc42604ee34c6d332 Cr-Commit-Position: refs/heads/master@{#400936} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
