Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor4_up_down_mac
Patch Set: Address review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 bool OnKeyPressed(const ui::KeyEvent& event) override; 172 bool OnKeyPressed(const ui::KeyEvent& event) override;
173 void OnGestureEvent(ui::GestureEvent* event) override; 173 void OnGestureEvent(ui::GestureEvent* event) override;
174 void AboutToRequestFocusFromTabTraversal(bool reverse) override; 174 void AboutToRequestFocusFromTabTraversal(bool reverse) override;
175 bool SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) override; 175 bool SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) override;
176 void GetAccessibleState(ui::AXViewState* state) override; 176 void GetAccessibleState(ui::AXViewState* state) override;
177 void OnFocus() override; 177 void OnFocus() override;
178 void OnBlur() override; 178 void OnBlur() override;
179 bool IsCommandIdEnabled(int command_id) const override; 179 bool IsCommandIdEnabled(int command_id) const override;
180 base::string16 GetSelectionClipboardText() const override; 180 base::string16 GetSelectionClipboardText() const override;
181 void DoInsertChar(base::char16 ch) override; 181 void DoInsertChar(base::char16 ch) override;
182 bool IsEditCommandEnabled(int command_id) const override; 182 bool IsTextEditCommandEnabled(ui::TextEditCommand command) const override;
183 void ExecuteEditCommand(int command_id) override; 183 void ExecuteTextEditCommand(ui::TextEditCommand command) override;
184 184
185 // chromeos::input_method::InputMethodManager::CandidateWindowObserver: 185 // chromeos::input_method::InputMethodManager::CandidateWindowObserver:
186 #if defined(OS_CHROMEOS) 186 #if defined(OS_CHROMEOS)
187 void CandidateWindowOpened( 187 void CandidateWindowOpened(
188 chromeos::input_method::InputMethodManager* manager) override; 188 chromeos::input_method::InputMethodManager* manager) override;
189 void CandidateWindowClosed( 189 void CandidateWindowClosed(
190 chromeos::input_method::InputMethodManager* manager) override; 190 chromeos::input_method::InputMethodManager* manager) override;
191 #endif 191 #endif
192 192
193 // views::TextfieldController: 193 // views::TextfieldController:
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 // painted. Used to measure omnibox responsiveness with a histogram. 254 // painted. Used to measure omnibox responsiveness with a histogram.
255 base::TimeTicks insert_char_time_; 255 base::TimeTicks insert_char_time_;
256 256
257 // Used to bind callback functions to this object. 257 // Used to bind callback functions to this object.
258 base::WeakPtrFactory<OmniboxViewViews> weak_ptr_factory_; 258 base::WeakPtrFactory<OmniboxViewViews> weak_ptr_factory_;
259 259
260 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews); 260 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
261 }; 261 };
262 262
263 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 263 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698