content/browser/renderer_host/render_widget_host_view_aura.h - Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor4_up_down_mac

Patch Set: Address review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_aura.h

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h

index b5f9fd7653a9bbf35b249b2235f278f93d7c6106..3a6e222059f8327eb412af92bf713e725c24f044 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.h

+++ b/content/browser/renderer_host/render_widget_host_view_aura.h

@@ -239,8 +239,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAura

base::i18n::TextDirection direction) override;

void ExtendSelectionAndDelete(size_t before, size_t after) override;

void EnsureCaretInRect(const gfx::Rect& rect) override;

- bool IsEditCommandEnabled(int command_id) const override;

- void SetEditCommandForNextKeyEvent(int command_id) override;

+ bool IsTextEditCommandEnabled(ui::TextEditCommand command) const override;

+ void SetTextEditCommandForNextKeyEvent(ui::TextEditCommand command) override;

// Overridden from display::DisplayObserver:

void OnDisplayAdded(const display::Display& new_display) override;

« no previous file with comments | « components/arc/ime/arc_ime_service.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »