components/arc/ime/arc_ime_service.cc - Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/ime/arc_ime_service.cc

Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor4_up_down_mac

Patch Set: Address review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/arc/ime/arc_ime_service.cc

diff --git a/components/arc/ime/arc_ime_service.cc b/components/arc/ime/arc_ime_service.cc

index c4f914fc65e7b532cab1680fb382f63b77535125..cb53c37b67c7d5b91056526540f8d50c0e64e0d5 100644

--- a/components/arc/ime/arc_ime_service.cc

+++ b/components/arc/ime/arc_ime_service.cc

@@ -281,7 +281,8 @@ bool ArcImeService::ChangeTextDirectionAndLayoutAlignment(

return false;

}

-bool ArcImeService::IsEditCommandEnabled(int command_id) const {

+bool ArcImeService::IsTextEditCommandEnabled(

+ ui::TextEditCommand command) const {

return false;

}

« no previous file with comments | « components/arc/ime/arc_ime_service.h ('k') | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | no next file with comments »