Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2026763002: Make use of new SkLights class (Closed)

Created:
4 years, 6 months ago by robertphillips
Modified:
4 years, 6 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org, dvonbeck
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Fix SampleApp slide #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -142 lines) Patch
M gm/lightingshader.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleLighting.cpp View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
D src/core/SkLight.h View 1 chunk +0 lines, -55 lines 0 comments Download
M src/core/SkLightingShader.h View 1 2 chunks +7 lines, -50 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 10 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
robertphillips
4 years, 6 months ago (2016-05-31 16:49:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026763002/20001
4 years, 6 months ago (2016-05-31 16:49:46 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/8810)
4 years, 6 months ago (2016-05-31 16:53:36 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026763002/40001
4 years, 6 months ago (2016-05-31 17:01:49 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 17:18:40 UTC) #12
egdaniel
lgtm
4 years, 6 months ago (2016-05-31 18:52:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026763002/40001
4 years, 6 months ago (2016-05-31 19:07:31 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:08:29 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/71e055279336096f92d63c5c855641b4b31d6a54

Powered by Google App Engine
This is Rietveld 408576698