Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 202203009: Rename |imp| => |impl| in bindings generation (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Rename |imp| => |impl| in bindings generation core/ and v8/ only use |impl|, while bindings/ uses half |imp| and half |impl|. This regularizes bindings to |impl|. BUG=345503 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169517

Patch Set 1 #

Patch Set 2 : custom/v8 too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2071 lines, -2071 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/attributes.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 14 chunks +23 lines, -23 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 10 chunks +22 lines, -22 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 26 chunks +78 lines, -78 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 22 chunks +49 lines, -49 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 12 chunks +24 lines, -24 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 16 chunks +35 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 36 chunks +98 lines, -98 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 290 chunks +585 lines, -585 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 432 chunks +888 lines, -888 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 8 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 14 chunks +30 lines, -30 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 18 chunks +39 lines, -39 lines 0 comments Download
M Source/bindings/v8/custom/V8BiquadFilterNodeCustom.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8DeviceMotionEventCustom.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8ElementCustom.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/custom/V8FileReaderCustom.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 4 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/v8/custom/V8NodeCustom.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8PannerNodeCustom.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/custom/V8WebGLRenderingContextBaseCustom.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 6 chunks +18 lines, -18 lines 0 comments Download
M Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Nils Barth (inactive)
Another clean-up.
6 years, 9 months ago (2014-03-18 04:51:37 UTC) #1
Nils Barth (inactive)
By way of background, my earlier CL: Simplify EventTarget bindings generation https://codereview.chromium.org/201603002/ ...started when I ...
6 years, 9 months ago (2014-03-18 04:52:33 UTC) #2
haraken
LGTM
6 years, 9 months ago (2014-03-18 06:35:37 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-19 02:52:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/202203009/20001
6 years, 9 months ago (2014-03-19 02:53:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 02:56:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 02:56:21 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-19 03:29:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/202203009/20001
6 years, 9 months ago (2014-03-19 03:29:27 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 03:32:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-19 03:32:23 UTC) #11
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-19 03:34:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/202203009/20001
6 years, 9 months ago (2014-03-19 03:34:21 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 03:57:58 UTC) #14
Message was sent while issue was closed. 
Change committed as 169517

Powered by Google App Engine
This is Rietveld 408576698