Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp

Issue 202203009: Rename |imp| => |impl| in bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: custom/v8 too Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "bindings/v8/ExceptionState.h" 29 #include "bindings/v8/ExceptionState.h"
30 #include "bindings/v8/V8Binding.h" 30 #include "bindings/v8/V8Binding.h"
31 #include "modules/webaudio/OscillatorNode.h" 31 #include "modules/webaudio/OscillatorNode.h"
32 32
33 namespace WebCore { 33 namespace WebCore {
34 34
35 void V8OscillatorNode::typeAttributeSetterCustom(v8::Local<v8::Value> value, con st v8::PropertyCallbackInfo<void>& info) 35 void V8OscillatorNode::typeAttributeSetterCustom(v8::Local<v8::Value> value, con st v8::PropertyCallbackInfo<void>& info)
36 { 36 {
37 ExceptionState exceptionState(ExceptionState::SetterContext, "type", "Oscill atorNode", info.Holder(), info.GetIsolate()); 37 ExceptionState exceptionState(ExceptionState::SetterContext, "type", "Oscill atorNode", info.Holder(), info.GetIsolate());
38 v8::Handle<v8::Object> holder = info.Holder(); 38 v8::Handle<v8::Object> holder = info.Holder();
39 OscillatorNode* imp = V8OscillatorNode::toNative(holder); 39 OscillatorNode* impl = V8OscillatorNode::toNative(holder);
40 40
41 if (value->IsNumber()) { 41 if (value->IsNumber()) {
42 uint32_t type = toUInt32(value, exceptionState); 42 uint32_t type = toUInt32(value, exceptionState);
43 if (exceptionState.throwIfNeeded()) 43 if (exceptionState.throwIfNeeded())
44 return; 44 return;
45 if (!imp->setType(type)) { 45 if (!impl->setType(type)) {
46 exceptionState.throwTypeError("Illegal OscillatorNode type"); 46 exceptionState.throwTypeError("Illegal OscillatorNode type");
47 exceptionState.throwIfNeeded(); 47 exceptionState.throwIfNeeded();
48 } 48 }
49 return; 49 return;
50 } 50 }
51 51
52 if (value->IsString()) { 52 if (value->IsString()) {
53 String type = toCoreString(value.As<v8::String>()); 53 String type = toCoreString(value.As<v8::String>());
54 if (type == "sine" || type == "square" || type == "sawtooth" || type == "triangle") { 54 if (type == "sine" || type == "square" || type == "sawtooth" || type == "triangle") {
55 imp->setType(type); 55 impl->setType(type);
56 return; 56 return;
57 } 57 }
58 } 58 }
59 59
60 exceptionState.throwTypeError("Illegal OscillatorNode type"); 60 exceptionState.throwTypeError("Illegal OscillatorNode type");
61 exceptionState.throwIfNeeded(); 61 exceptionState.throwIfNeeded();
62 } 62 }
63 63
64 } // namespace WebCore 64 } // namespace WebCore
65 65
66 #endif // ENABLE(WEB_AUDIO) 66 #endif // ENABLE(WEB_AUDIO)
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8NodeCustom.cpp ('k') | Source/bindings/v8/custom/V8PannerNodeCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698