Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 202203009: Rename |imp| => |impl| in bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: custom/v8 too Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index d7cfb56cc4f640123dcedf61d78f0e210c00440a..22e8796e2a2c1acde998318bb91058089844131f 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -183,7 +183,7 @@ def generate_getter(interface, attribute, contents):
def v8_set_return_value_statement(for_main_world=False):
if contents['is_keep_alive_for_gc']:
return 'v8SetReturnValue(info, wrapper)'
- return idl_type.v8_set_return_value(cpp_value, extended_attributes=extended_attributes, script_wrappable='imp', release=release, for_main_world=for_main_world)
+ return idl_type.v8_set_return_value(cpp_value, extended_attributes=extended_attributes, script_wrappable='impl', release=release, for_main_world=for_main_world)
contents.update({
'cpp_value': cpp_value,
@@ -200,7 +200,7 @@ def getter_expression(interface, attribute, contents):
arguments.extend(v8_utilities.call_with_arguments(attribute))
if ('ImplementedBy' in attribute.extended_attributes and
not attribute.is_static):
- arguments.append('*imp')
+ arguments.append('*impl')
if attribute.idl_type.is_nullable:
arguments.append('isNull')
if contents['is_getter_raises_exception']:
@@ -296,7 +296,7 @@ def setter_expression(interface, attribute, contents):
if ('ImplementedBy' in extended_attributes and
not attribute.is_static):
- arguments.append('*imp')
+ arguments.append('*impl')
idl_type = attribute.idl_type
if idl_type.base_type == 'EventHandler':
getter_name = scoped_name(interface, attribute, cpp_name(attribute))
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698