Source/bindings/scripts/v8_methods.py - Issue 202203009: Rename |imp| => |impl| in bindings generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 202203009: Rename |imp| => |impl| in bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: custom/v8 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 6296a0d8a0a7cc288361d162f7560af6a19975f1..066b998bd762c2bb0f8dca9a5eee397780b75bd1 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -183,7 +183,7 @@ def cpp_value(interface, method, number_of_arguments):

cpp_arguments = v8_utilities.call_with_arguments(method)

if ('ImplementedBy' in method.extended_attributes and

not method.is_static):

- cpp_arguments.append('*imp')

+ cpp_arguments.append('*impl')

cpp_arguments.extend(cpp_argument(argument) for argument in arguments)

this_union_arguments = method.idl_type.union_arguments

if this_union_arguments:

@@ -210,7 +210,7 @@ def v8_set_return_value(interface_name, method, cpp_value, for_main_world=False)

cpp_value = 'result' # use local variable for value

release = idl_type.release

- script_wrappable = 'imp' if inherits_interface(interface_name, 'Node') else ''

+ script_wrappable = 'impl' if inherits_interface(interface_name, 'Node') else ''

return idl_type.v8_set_return_value(cpp_value, extended_attributes, script_wrappable=script_wrappable, release=release, for_main_world=for_main_world)

« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »