Source/bindings/scripts/v8_interface.py - Issue 202203009: Rename |imp| => |impl| in bindings generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 202203009: Rename |imp| => |impl| in bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: custom/v8 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 7296a1b6afb58ad6a913fb4814b0467e45fc17aa..09442160ea0526455b60536fbef654d390633477 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -549,7 +549,7 @@ def property_getter(getter, cpp_arguments):

is_raises_exception = 'RaisesException' in extended_attributes

# FIXME: make more generic, so can use v8_methods.cpp_value

- cpp_method_name = 'imp->%s' % cpp_name(getter)

+ cpp_method_name = 'impl->%s' % cpp_name(getter)

if is_raises_exception:

cpp_arguments.append('exceptionState')

@@ -575,7 +575,7 @@ def property_getter(getter, cpp_arguments):

'is_raises_exception': is_raises_exception,

'name': cpp_name(getter),

'union_arguments': union_arguments,

- 'v8_set_return_value': idl_type.v8_set_return_value('result', extended_attributes=extended_attributes, script_wrappable='imp', release=idl_type.release),

+ 'v8_set_return_value': idl_type.v8_set_return_value('result', extended_attributes=extended_attributes, script_wrappable='impl', release=idl_type.release),

}

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »