Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(91)

Issue 20208: Lots of small nits to help to split off webkit.dll.... (Closed)

Created:
10 years, 6 months ago by M-A Ruel
Modified:
8 years, 3 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Lots of small nits to help to split off webkit.dll. - Stop directly referencing WebPluginDelegateImpl. - Make the password manager to not allocation the data on heap. - Remove some unneeded includes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9692

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 3

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -107 lines) Patch
M base/clipboard.h View 1 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download
M base/clipboard_win.cc View 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M base/scoped_clipboard_writer.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill_manager.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill_manager.cc View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 2 3 4 5 6 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 2 3 4 5 6 10 chunks +17 lines, -16 lines 0 comments Download
M chrome/renderer/render_view.cc View 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/password_form_dom_manager.h View 1 2 3 4 5 6 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/glue/password_form_dom_manager.cc View 1 2 3 4 5 6 2 chunks +3 lines, -6 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 1 2 3 4 5 6 4 chunks +9 lines, -25 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_gtk.cc View 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_mac.cc View 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/scoped_clipboard_writer_glue.h View 1 2 3 4 5 6 1 chunk +6 lines, -1 line 0 comments Download
M webkit/glue/webkit_glue.cc View 1 2 3 4 5 6 3 chunks +28 lines, -21 lines 0 comments Download
M webkit/glue/webplugin_delegate.h View 1 2 3 4 5 6 3 chunks +45 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
10 years, 6 months ago (2009-02-10 02:29:40 UTC) #1
darin (slow to review)
Good stuff... http://codereview.chromium.org/20208/diff/1069/1081 File chrome/browser/password_manager/password_manager.cc (right): http://codereview.chromium.org/20208/diff/1069/1081#newcode232 Line 232: PasswordFormDomManager::CreateFillData(&fill_data, nit: it would be good ...
10 years, 6 months ago (2009-02-10 20:40:19 UTC) #2
darin (slow to review)
Good stuff...
10 years, 6 months ago (2009-02-10 20:40:24 UTC) #3
M-A Ruel
Issues fixed. Fixed linux and mac too.
10 years, 6 months ago (2009-02-12 15:20:41 UTC) #4
darin (slow to review)
10 years, 6 months ago (2009-02-12 19:33:53 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698