Lots of small nits to help to split off webkit.dll....

webkit/glue/password_form_dom_manager.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "base/compiler_specific.h"
 
 MSVC_PUSH_WARNING_LEVEL(0);
 #include "Document.h"
@@ skipping 44 matching lines @@
   WebCore::HTMLInputElement* old_password = NULL;
   if (!LocateSpecificPasswords(&fields, &password, &old_password))
     return NULL;
 
   return AssemblePasswordFormResult(full_origin, full_action, 
                                     fields.submit, fields.username,
                                     old_password, password);
 }
 
 // static
-PasswordFormDomManager::FillData* PasswordFormDomManager::CreateFillData(
+void PasswordFormDomManager::InitFillData(
     const PasswordForm& form_on_page, 
     const PasswordFormMap& matches, 
     const PasswordForm* const preferred_match,
-    bool wait_for_username_before_autofill) {
+    bool wait_for_username_before_autofill,
+    PasswordFormDomManager::FillData* result) {
   DCHECK(preferred_match);
-  PasswordFormDomManager::FillData* result = 
-      new PasswordFormDomManager::FillData();
-
   // Fill basic form data.
   result->basic_data.origin = form_on_page.origin;
   result->basic_data.action = form_on_page.action;
   result->basic_data.elements.push_back(form_on_page.username_element);
   result->basic_data.values.push_back(preferred_match->username_value);
   result->basic_data.elements.push_back(form_on_page.password_element);
   result->basic_data.values.push_back(preferred_match->password_value);
   result->basic_data.submit = form_on_page.submit_element;
   result->wait_for_username = wait_for_username_before_autofill;
 
   // Copy additional username/value pairs.
   PasswordFormMap::const_iterator iter;
   for (iter = matches.begin(); iter != matches.end(); iter++) {
     if (iter->second != preferred_match) 
       result->additional_logins[iter->first] = iter->second->password_value;
   }
-  return result;
 }
 
 // static
 bool PasswordFormDomManager::LocateSpecificPasswords(
     PasswordFormFields* fields,
     WebCore::HTMLInputElement** password,
     WebCore::HTMLInputElement** old_password) {
   DCHECK(fields && password && old_password);
   switch (fields->passwords.size()) {
     case 1:
@@ skipping 169 matching lines @@
           : webkit_glue::StringToStdWString(password->value());
   result->old_password_element =
       old_password == NULL ? empty 
           : webkit_glue::StringToStdWString(old_password->name());
   result->old_password_value =
       old_password == NULL ? empty 
           : webkit_glue::StringToStdWString(old_password->value());
   return result;
 }