Lots of small nits to help to split off webkit.dll....

webkit/glue/webkit_glue.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <objidl.h>
 #include <mlang.h>
@@ skipping 17 matching lines @@
 #include "RenderTreeAsText.h"
 #include "RenderView.h"
 #include "ScriptController.h"
 #include "SharedBuffer.h"
 MSVC_POP_WARNING();
 
 #undef LOG
 #include "webkit/glue/webkit_glue.h"
 
 #include "base/file_version_info.h"
+#include "base/singleton.h"
 #include "base/string_util.h"
 #include "skia/include/SkBitmap.h"
 #include "webkit/glue/event_conversion.h"
 #include "webkit/glue/glue_util.h"
 #include "webkit/glue/weburlrequest_impl.h"
 #include "webkit/glue/webframe_impl.h"
 #include "webkit/glue/webview_impl.h"
 
 //------------------------------------------------------------------------------
 // webkit_glue impl:
@@ skipping 261 matching lines @@
     return;
   delegate->OnNavStateChanged(webview);
 }
 
 std::string GetWebKitVersion() {
   return StringPrintf("%d.%d", WEBKIT_VERSION_MAJOR, WEBKIT_VERSION_MINOR);
 }
 
 namespace {
 
-const std::string* user_agent = NULL;
-bool user_agent_requested = false;
-bool user_agent_is_overridden = false;
+struct UserAgentState {
+  UserAgentState()
+      : user_agent_requested(false),
+        user_agent_is_overridden(false) {
+  }
+
+  std::string user_agent;
+  std::string mimic_safari_user_agent;
+  bool user_agent_requested;
+  bool user_agent_is_overridden;
+};
+
+Singleton<UserAgentState> g_user_agent;
 
 void BuildUserAgent(bool mimic_safari, std::string* result) {
 #if defined(OS_WIN) || defined(OS_MACOSX)
   int32 os_major_version = 0;
   int32 os_minor_version = 0;
   int32 os_bugfix_version = 0;
 #if defined(OS_WIN)
   OSVERSIONINFO info = {0};
   info.dwOSVersionInfoSize = sizeof(info);
   GetVersionEx(&info);
@@ skipping 53 matching lines @@
       result,
       "Mozilla/5.0 (Linux; U; en-US) AppleWebKit/525.13 "
       "(KHTML, like Gecko) Chrome/0.2.149.27 Safari/525.13");
 #else
   // TODO(port): we need something like FileVersionInfo for our UA string.
   NOTIMPLEMENTED();
 #endif
 }
 
 void SetUserAgentToDefault() {
-  static std::string default_user_agent;
-  BuildUserAgent(false, &default_user_agent);
-  user_agent = &default_user_agent;
+  BuildUserAgent(false, &g_user_agent->user_agent);
 }
 
 }  // namespace
 
 void SetUserAgent(const std::string& new_user_agent) {
-  DCHECK(!user_agent_requested) << "Setting the user agent after someone has "
+  // If you combine this with the previous line, the function only works the
+  // first time.
+  DCHECK(!g_user_agent->user_agent_requested) <<
+      "Setting the user agent after someone has "
       "already requested it can result in unexpected behavior.";
-  static std::string overridden_user_agent;
-  overridden_user_agent = new_user_agent;  // If you combine this with the
-                                           // previous line, the function only
-                                           // works the first time.
-  user_agent_is_overridden = true;
-  user_agent = &overridden_user_agent;
+  g_user_agent->user_agent_is_overridden = true;
+  g_user_agent->user_agent = new_user_agent;
 }
 
 const std::string& GetUserAgent(const GURL& url) {
-  if (!user_agent)
+  if (g_user_agent->user_agent.empty())
     SetUserAgentToDefault();
-  user_agent_requested = true;
-  if (!user_agent_is_overridden) {
-    static std::string mimic_safari_user_agent;
+  g_user_agent->user_agent_requested = true;
+  if (!g_user_agent->user_agent_is_overridden) {
     // For hotmail, we need to spoof as Safari (bug 4111).
     if (MatchPattern(url.host(), "*.mail.live.com")) {
-      if (mimic_safari_user_agent.empty()) 
-        BuildUserAgent(true, &mimic_safari_user_agent);
-      return mimic_safari_user_agent;
+      if (g_user_agent->mimic_safari_user_agent.empty()) 
+        BuildUserAgent(true, &g_user_agent->mimic_safari_user_agent);
+      return g_user_agent->mimic_safari_user_agent;
     }
   }
-  return *user_agent;
+  return g_user_agent->user_agent;
 }
 
 void NotifyJSOutOfMemory(WebCore::Frame* frame) {
   if (!frame)
     return;
 
   // Dispatch to the delegate of the view that owns the frame.
   WebFrame* webframe = WebFrameImpl::FromFrame(frame);
   WebView* webview = webframe->GetView();
   if (!webview)
@@ skipping 11 matching lines @@
   }
 
   g_forcefully_terminate_plugin_process = value;
 }
 
 bool ShouldForcefullyTerminatePluginProcess() {
   return g_forcefully_terminate_plugin_process;
 }
 
 } // namespace webkit_glue