Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: webkit/glue/password_form_dom_manager.h

Issue 20208: Lots of small nits to help to split off webkit.dll.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | webkit/glue/password_form_dom_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PASSWORD_FORM_DOM_MANAGER_H__ 5 #ifndef WEBKIT_GLUE_PASSWORD_FORM_DOM_MANAGER_H__
6 #define WEBKIT_GLUE_PASSWORD_FORM_DOM_MANAGER_H__ 6 #define WEBKIT_GLUE_PASSWORD_FORM_DOM_MANAGER_H__
7 7
8 #include "webkit/glue/form_data.h" 8 #include "webkit/glue/form_data.h"
9 #include "webkit/glue/password_form.h" 9 #include "webkit/glue/password_form.h"
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // happens with a given form and compare against previously Create'd forms 45 // happens with a given form and compare against previously Create'd forms
46 // to identify..which sucks. 46 // to identify..which sucks.
47 static PasswordForm* CreatePasswordForm(WebCore::HTMLFormElement* form); 47 static PasswordForm* CreatePasswordForm(WebCore::HTMLFormElement* form);
48 48
49 // Create a FillData structure in preparation for autofilling a form, 49 // Create a FillData structure in preparation for autofilling a form,
50 // from basic_data identifying which form to fill, and a collection of 50 // from basic_data identifying which form to fill, and a collection of
51 // matching stored logins to use as username/password values. 51 // matching stored logins to use as username/password values.
52 // preferred_match should equal (address) one of matches. 52 // preferred_match should equal (address) one of matches.
53 // wait_for_username_before_autofill is true if we should not autofill 53 // wait_for_username_before_autofill is true if we should not autofill
54 // anything until the user typed in a valid username and blurred the field. 54 // anything until the user typed in a valid username and blurred the field.
55 static FillData* CreateFillData(const PasswordForm& form_on_page, 55 static void InitFillData(const PasswordForm& form_on_page,
56 const PasswordFormMap& matches, 56 const PasswordFormMap& matches,
57 const PasswordForm* const preferred_match, 57 const PasswordForm* const preferred_match,
58 bool wait_for_username_before_autofill); 58 bool wait_for_username_before_autofill,
59 FillData* result);
59 private: 60 private:
60 // Helper structure to locate username, passwords and submit fields. 61 // Helper structure to locate username, passwords and submit fields.
61 struct PasswordFormFields { 62 struct PasswordFormFields {
62 WebCore::HTMLInputElement* username; 63 WebCore::HTMLInputElement* username;
63 std::vector<WebCore::HTMLInputElement*> passwords; 64 std::vector<WebCore::HTMLInputElement*> passwords;
64 WebCore::HTMLFormControlElement* submit; 65 WebCore::HTMLFormControlElement* submit;
65 PasswordFormFields() : username(NULL), submit(NULL) { 66 PasswordFormFields() : username(NULL), submit(NULL) {
66 } 67 }
67 }; 68 };
68 69
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 WebCore::HTMLInputElement* username, 126 WebCore::HTMLInputElement* username,
126 WebCore::HTMLInputElement* old_password, 127 WebCore::HTMLInputElement* old_password,
127 WebCore::HTMLInputElement* password); 128 WebCore::HTMLInputElement* password);
128 129
129 // This class can't be instantiated. 130 // This class can't be instantiated.
130 DISALLOW_IMPLICIT_CONSTRUCTORS(PasswordFormDomManager); 131 DISALLOW_IMPLICIT_CONSTRUCTORS(PasswordFormDomManager);
131 }; 132 };
132 133
133 #endif // WEBKIT_GLUE_PASSWORD_FORM_DOM_MANAGER_H__ 134 #endif // WEBKIT_GLUE_PASSWORD_FORM_DOM_MANAGER_H__
134 135
OLDNEW
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | webkit/glue/password_form_dom_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698