Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: webkit/glue/plugins/webplugin_delegate_impl_gtk.cc

Issue 20208: Lots of small nits to help to split off webkit.dll.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // HACK: we need this #define in place before npapi.h is included for 5 // HACK: we need this #define in place before npapi.h is included for
6 // plugins to work. However, all sorts of headers include npapi.h, so 6 // plugins to work. However, all sorts of headers include npapi.h, so
7 // the only way to be certain the define is in place is to put it 7 // the only way to be certain the define is in place is to put it
8 // here. You might ask, "Why not set it in npapi.h directly, or in 8 // here. You might ask, "Why not set it in npapi.h directly, or in
9 // this directory's SConscript, then?" but it turns out this define 9 // this directory's SConscript, then?" but it turns out this define
10 // makes npapi.h include Xlib.h, which in turn defines a ton of symbols 10 // makes npapi.h include Xlib.h, which in turn defines a ton of symbols
(...skipping 19 matching lines...) Expand all
30 // #include "webkit/default_plugin/plugin_impl.h" 30 // #include "webkit/default_plugin/plugin_impl.h"
31 #include "webkit/glue/glue_util.h" 31 #include "webkit/glue/glue_util.h"
32 #include "webkit/glue/webplugin.h" 32 #include "webkit/glue/webplugin.h"
33 #include "webkit/glue/plugins/plugin_constants_win.h" 33 #include "webkit/glue/plugins/plugin_constants_win.h"
34 #include "webkit/glue/plugins/plugin_instance.h" 34 #include "webkit/glue/plugins/plugin_instance.h"
35 #include "webkit/glue/plugins/plugin_lib.h" 35 #include "webkit/glue/plugins/plugin_lib.h"
36 #include "webkit/glue/plugins/plugin_list.h" 36 #include "webkit/glue/plugins/plugin_list.h"
37 #include "webkit/glue/plugins/plugin_stream_url.h" 37 #include "webkit/glue/plugins/plugin_stream_url.h"
38 #include "webkit/glue/webkit_glue.h" 38 #include "webkit/glue/webkit_glue.h"
39 39
40 WebPluginDelegateImpl* WebPluginDelegateImpl::Create( 40 WebPluginDelegate* WebPluginDelegate::Create(
41 const FilePath& filename, 41 const FilePath& filename,
42 const std::string& mime_type, 42 const std::string& mime_type,
43 gfx::NativeView containing_view) { 43 gfx::NativeView containing_view) {
44 scoped_refptr<NPAPI::PluginLib> plugin = 44 scoped_refptr<NPAPI::PluginLib> plugin =
45 NPAPI::PluginLib::CreatePluginLib(filename); 45 NPAPI::PluginLib::CreatePluginLib(filename);
46 if (plugin.get() == NULL) 46 if (plugin.get() == NULL)
47 return NULL; 47 return NULL;
48 48
49 NPError err = plugin->NP_Initialize(); 49 NPError err = plugin->NP_Initialize();
50 if (err != NPERR_NO_ERROR) 50 if (err != NPERR_NO_ERROR)
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 609
610 void WebPluginDelegateImpl::URLRequestRouted(const std::string&url, 610 void WebPluginDelegateImpl::URLRequestRouted(const std::string&url,
611 bool notify_needed, 611 bool notify_needed,
612 void* notify_data) { 612 void* notify_data) {
613 if (notify_needed) { 613 if (notify_needed) {
614 instance()->SetURLLoadData(GURL(url.c_str()), notify_data); 614 instance()->SetURLLoadData(GURL(url.c_str()), notify_data);
615 } 615 }
616 } 616 }
617 617
618 618
OLDNEW
« no previous file with comments | « webkit/glue/plugins/webplugin_delegate_impl.cc ('k') | webkit/glue/plugins/webplugin_delegate_impl_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698