Chromium Code Reviews
Description[Media Router WebUI] Show issue's secondary action when 'dismiss'.
The action type 'dismiss' maps to 0. Currently, we don't check whether it's undefined, but if it is truthy. if(0) is always false. This means that if the secondary button is 'dismiss', it will not be shown.
This was previously not caught as the tests mark non-existent secondary actions as null rather than undefined.
BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1998013003
Cr-Commit-Position: refs/heads/master@{#395394}
(cherry picked from commit 8d0894e8a5b6c29e97704a62ca75cc1cb412223d)
Committed: https://chromium.googlesource.com/chromium/src/+/802c756a74fcabb788563982e2ba48a152132019
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||