Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2014673002: [Media Router WebUI] Show issue's secondary action when 'dismiss'. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Show issue's secondary action when 'dismiss'. The action type 'dismiss' maps to 0. Currently, we don't check whether it's undefined, but if it is truthy. if(0) is always false. This means that if the secondary button is 'dismiss', it will not be shown. This was previously not caught as the tests mark non-existent secondary actions as null rather than undefined. BUG=613253 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1998013003 Cr-Commit-Position: refs/heads/master@{#395394} (cherry picked from commit 8d0894e8a5b6c29e97704a62ca75cc1cb412223d) Committed: https://chromium.googlesource.com/chromium/src/+/802c756a74fcabb788563982e2ba48a152132019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/media_router/media_router_data.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/media_router/issue_banner_tests.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 7 months ago (2016-05-25 18:30:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
802c756a74fcabb788563982e2ba48a152132019.

Powered by Google App Engine
This is Rietveld 408576698