Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/test/data/webui/media_router/issue_banner_tests.js

Issue 2014673002: [Media Router WebUI] Show issue's secondary action when 'dismiss'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/media_router/media_router_data.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/media_router/issue_banner_tests.js
diff --git a/chrome/test/data/webui/media_router/issue_banner_tests.js b/chrome/test/data/webui/media_router/issue_banner_tests.js
index a5046b7b1c8cee47a396879569612dcdb66d3e15..85be90938c9ae94cfd971a0ca829bf0fc48ad181 100644
--- a/chrome/test/data/webui/media_router/issue_banner_tests.js
+++ b/chrome/test/data/webui/media_router/issue_banner_tests.js
@@ -79,8 +79,8 @@ cr.define('issue_banner', function() {
};
// Checks whether parts of the UI is visible.
- var checkButtonVisibility = function(hasOptAction) {
- assertEquals(!hasOptAction, banner.$['buttons']
+ var checkButtonVisibility = function(optAction) {
+ assertEquals(!optAction, banner.$['buttons']
.querySelector('paper-button').hidden);
};
@@ -102,13 +102,13 @@ cr.define('issue_banner', function() {
'issue id 1', 'Issue Title 1', 'Issue Message 1', 0, 1,
'route id 1', true, 1234);
fakeBlockingIssueTwo = new media_router.Issue(
- 'issue id 2', 'Issue Title 2', 'Issue Message 2', 0, null,
+ 'issue id 2', 'Issue Title 2', 'Issue Message 2', 0, undefined,
'route id 2', true, 1234);
fakeNonBlockingIssueOne = new media_router.Issue(
'issue id 3', 'Issue Title 3', 'Issue Message 3', 0, 1,
'route id 3', false, 1234);
fakeNonBlockingIssueTwo = new media_router.Issue(
- 'issue id 4', 'Issue Title 4', 'Issue Message 4', 0, null,
+ 'issue id 4', 'Issue Title 4', 'Issue Message 4', 0, undefined,
'route id 4', false, 1234);
// Allow for the issue banner to be created and attached.
« no previous file with comments | « chrome/browser/resources/media_router/media_router_data.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698