chrome/browser/resources/media_router/media_router_data.js - Issue 2014673002: [Media Router WebUI] Show issue's secondary action when 'dismiss'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/media_router_data.js

Issue 2014673002: [Media Router WebUI] Show issue's secondary action when 'dismiss'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js ('k') | chrome/test/data/webui/media_router/issue_banner_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/media_router_data.js

diff --git a/chrome/browser/resources/media_router/media_router_data.js b/chrome/browser/resources/media_router/media_router_data.js

index 9f5e3f4438788203dc8ec1306309412ffa065185..d7bd5f79cecb7e1022abd0d23a58ab4a583c2494 100644

--- a/chrome/browser/resources/media_router/media_router_data.js

+++ b/chrome/browser/resources/media_router/media_router_data.js

@@ -127,7 +127,7 @@ cr.define('media_router', function() {

* @param {string} title The issue title.

* @param {string} message The issue message.

* @param {number} defaultActionType The type of default action.

- * @param {?number} secondaryActionType The type of optional action.

+ * @param {number|undefined} secondaryActionType The type of optional action.

* @param {?string} routeId The route ID to which this issue

* pertains. If not set, this is a global issue.

* @param {boolean} isBlocking True if this issue blocks other UI.

@@ -150,7 +150,7 @@ cr.define('media_router', function() {

/** @type {number} */

this.defaultActionType = defaultActionType;

- /** @type {?number} */

+ /** @type {number|undefined} */

this.secondaryActionType = secondaryActionType;

/** @type {?string} */