[Media Router WebUI] Show issue's secondary action when 'dismiss'.

[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's undefined, but if it is truthy. if(0) is always false. This means that if the secondary button is 'dismiss', it will not be shown.

This was previously not caught as the tests mark non-existent secondary actions as null rather than undefined.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8d0894e8a5b6c29e97704a62ca75cc1cb412223d
Cr-Commit-Position: refs/heads/master@{#395394}

[apacible, 2016-05-20 16:14:35]

Description was changed from

==========
asdf

BUG=
==========

to

==========
asdf

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-20 16:19:24]

Description was changed from

==========
asdf

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Show issue's secondary action when 'default'.

The action type 'default' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-20 16:19:25]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-05-20 16:20:54]

Description was changed from

==========
[Media Router WebUI] Show issue's secondary action when 'default'.

The action type 'default' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false. This means that if the
secondary button is 'dismiss', it will not be shown.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-20 16:31:07]

Patchset #1 (id:1) has been deleted

[apacible, 2016-05-20 16:31:14]

Patchset #1 (id:20001) has been deleted

[apacible, 2016-05-20 16:39:49]

Description was changed from

==========
[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false. This means that if the
secondary button is 'dismiss', it will not be shown.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false. This means that if the
secondary button is 'dismiss', it will not be shown.

This was previously not caught as the tests mark non-existent secondary actions
as null rather than undefined.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-20 16:40:13]

Patchset #1 (id:40001) has been deleted

[apacible, 2016-05-20 16:40:22]

PTAL, thanks!

[imcheng, 2016-05-23 18:33:36]

lgtm

[apacible, 2016-05-23 18:51:28]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2016-05-23 18:51:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998013003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998013003/60001

[commit-bot: I haz the power, 2016-05-23 19:59:17]

Description was changed from

==========
[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false. This means that if the
secondary button is 'dismiss', it will not be shown.

This was previously not caught as the tests mark non-existent secondary actions
as null rather than undefined.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false. This means that if the
secondary button is 'dismiss', it will not be shown.

This was previously not caught as the tests mark non-existent secondary actions
as null rather than undefined.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-23 19:59:18]

Committed patchset #1 (id:60001)

[commit-bot: I haz the power, 2016-05-23 20:00:25]

Description was changed from

==========
[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false. This means that if the
secondary button is 'dismiss', it will not be shown.

This was previously not caught as the tests mark non-existent secondary actions
as null rather than undefined.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Show issue's secondary action when 'dismiss'.

The action type 'dismiss' maps to 0. Currently, we don't check whether it's
undefined, but if it is truthy. if(0) is always false. This means that if the
secondary button is 'dismiss', it will not be shown.

This was previously not caught as the tests mark non-existent secondary actions
as null rather than undefined.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8d0894e8a5b6c29e97704a62ca75cc1cb412223d
Cr-Commit-Position: refs/heads/master@{#395394}
==========

[commit-bot: I haz the power, 2016-05-23 20:00:26]

Patchset 1 (id:??) landed as
https://crrev.com/8d0894e8a5b6c29e97704a62ca75cc1cb412223d
Cr-Commit-Position: refs/heads/master@{#395394}