chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js - Issue 2014673002: [Media Router WebUI] Show issue's secondary action when 'dismiss'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

Issue 2014673002: [Media Router WebUI] Show issue's secondary action when 'dismiss'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

diff --git a/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

index 324360fb837f2ee3cb69a61711cf8f5da7a26a09..4698589dc753358c744b73da3cdf78d378f05e04 100644

--- a/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

+++ b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

@@ -80,7 +80,7 @@ Polymer({

* @private

computeOptionalActionHidden_: function(issue) {

- return !issue || !issue.secondaryActionType;

+ return !issue || issue.secondaryActionType === undefined;

/**

@@ -132,7 +132,7 @@ Polymer({

this.i18n(this.actionTypeToButtonTextResource_[

this.issue.defaultActionType]);

- if (this.issue.secondaryActionType) {

+ if (this.issue.secondaryActionType !== undefined) {

secondaryText =

this.i18n(this.actionTypeToButtonTextResource_[

this.issue.secondaryActionType]);

« no previous file with comments | « no previous file | chrome/browser/resources/media_router/media_router_data.js » ('j') | no next file with comments »