Begin using ChromeVox Next to read tab and window titles.

Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed announcements, ChromeVox can compute output that takes into account eh focused node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally the window gets read
ctrl+tab: similar to above, except window isn't included (diff of ancestry chains). This cleaned up some of the previous hacks to focus the root web area. Selection had been set to the tab node; now, ensure the selection target is a descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page programmatically sets it at around load time. The tabs api handler logic reads out the tab using the url since it has nothing at creation time.

BUG=613182
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c
Cr-Commit-Position: refs/heads/master@{#396314}

[David Tseng, 2016-05-23 23:00:47]

Description was changed from

==========
Begin using ChromeVox Next to read tab and window titles.
==========

to

==========
Begin using ChromeVox Next to read tab and window titles.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-24 23:12:59]

Description was changed from

==========
Begin using ChromeVox Next to read tab and window titles.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.


CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-24 23:12:59]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-05-24 23:13:46]

This is still wip because of test failures (mostly flakeyness at the
chromevox/testing/ level).

[David Tseng, 2016-05-24 23:44:21]

Description was changed from

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.


CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window get read
ctrl+tab: similar to above, expect window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.


CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-24 23:49:03]

Description was changed from

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window get read
ctrl+tab: similar to above, expect window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.


CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window get read
ctrl+tab: similar to above, expect window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.

BUG=613182

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-24 23:50:47]

Description was changed from

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window get read
ctrl+tab: similar to above, expect window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.

BUG=613182

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window gets read
ctrl+tab: similar to above, except window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.

BUG=613182

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-05-25 15:18:00]

lgtm

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
(left):

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js:54:
if (!evt.target.docUrl || evt.target.docUrl != newTabUrl)
I think making this change could break tests with iframes. We need runWithTab to
be able to wait for a specific loadComplete, not just any loadComplete.

https://codereview.chromium.org/2008773002/diff/20001/ui/views/accessibility/...
File ui/views/accessibility/ax_window_obj_wrapper.cc (right):

https://codereview.chromium.org/2008773002/diff/20001/ui/views/accessibility/...
ui/views/accessibility/ax_window_obj_wrapper.cc:69:
AXAuraObjCache::GetInstance()->Remove(window);
Does it get re-added? Why delete it rather than triggering an event on it?

[David Tseng, 2016-05-25 16:08:23]

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
(left):

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js:54:
if (!evt.target.docUrl || evt.target.docUrl != newTabUrl)
On 2016/05/25 15:18:00, dmazzoni wrote:
> I think making this change could break tests with iframes. We need runWithTab
to
> be able to wait for a specific loadComplete, not just any loadComplete.

I'm a little surprised this worked before because we add the listener
potentially after the tab already opens.

https://codereview.chromium.org/2008773002/diff/20001/ui/views/accessibility/...
File ui/views/accessibility/ax_window_obj_wrapper.cc (right):

https://codereview.chromium.org/2008773002/diff/20001/ui/views/accessibility/...
ui/views/accessibility/ax_window_obj_wrapper.cc:69:
AXAuraObjCache::GetInstance()->Remove(window);
On 2016/05/25 15:18:00, dmazzoni wrote:
> Does it get re-added? Why delete it rather than triggering an event on it?

Removed this; went with adding the name on the widget (similarly to RootView).

The issue with firing an event is we don't have the plumbing to dispatch an
event on Widget or Window. I think for other platforms, we never needed it.
However, for automation, we need these backing objects to maintain the tree
state in the browser for AXTree.

[dmazzoni, 2016-05-25 16:10:35]

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
(left):

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js:54:
if (!evt.target.docUrl || evt.target.docUrl != newTabUrl)
On 2016/05/25 16:08:23, David Tseng wrote:
> On 2016/05/25 15:18:00, dmazzoni wrote:
> > I think making this change could break tests with iframes. We need
runWithTab
> to
> > be able to wait for a specific loadComplete, not just any loadComplete.
> 
> I'm a little surprised this worked before because we add the listener
> potentially after the tab already opens.

That's true, it'd probably be better to register the listener first.

[David Tseng, 2016-05-25 17:27:28]

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
(left):

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js:54:
if (!evt.target.docUrl || evt.target.docUrl != newTabUrl)
On 2016/05/25 16:10:35, dmazzoni wrote:
> On 2016/05/25 16:08:23, David Tseng wrote:
> > On 2016/05/25 15:18:00, dmazzoni wrote:
> > > I think making this change could break tests with iframes. We need
> runWithTab
> > to
> > > be able to wait for a specific loadComplete, not just any loadComplete.

Added the ability to wait for a specific url and a utility method to create a
url for a data doc (applying what seem to be the same string operations
accessibility does).

At the moment, I'm seeing load complete fired on the root after iframes. If that
changes, we can use the above.

> > 
> > I'm a little surprised this worked before because we add the listener
> > potentially after the tab already opens.
> 
> That's true, it'd probably be better to register the listener first.

[dmazzoni, 2016-05-25 21:41:06]

lgtm

[David Tseng, 2016-05-26 20:49:16]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-05-26 20:49:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2008773002/#ps120001
(title: "Fix a bunch of tests.")

[commit-bot: I haz the power, 2016-05-26 20:50:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008773002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008773002/120001

[David Tseng, 2016-05-26 20:50:19]

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
(left):

https://codereview.chromium.org/2008773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js:54:
if (!evt.target.docUrl || evt.target.docUrl != newTabUrl)
On 2016/05/25 17:27:28, David Tseng wrote:
> On 2016/05/25 16:10:35, dmazzoni wrote:
> > On 2016/05/25 16:08:23, David Tseng wrote:
> > > On 2016/05/25 15:18:00, dmazzoni wrote:
> > > > I think making this change could break tests with iframes. We need
> > runWithTab
> > > to
> > > > be able to wait for a specific loadComplete, not just any loadComplete.


FYI; I filed
crbug.com/615192> 

> Added the ability to wait for a specific url and a utility method to create a
> url for a data doc (applying what seem to be the same string operations
> accessibility does).
> 
> At the moment, I'm seeing load complete fired on the root after iframes. If
that
> changes, we can use the above.
> 
> > > 
> > > I'm a little surprised this worked before because we add the listener
> > > potentially after the tab already opens.
> > 
> > That's true, it'd probably be better to register the listener first.
>

[commit-bot: I haz the power, 2016-05-26 23:26:22]

Description was changed from

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window gets read
ctrl+tab: similar to above, except window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.

BUG=613182

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window gets read
ctrl+tab: similar to above, except window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.

BUG=613182

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-26 23:26:24]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-26 23:27:50]

Description was changed from

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window gets read
ctrl+tab: similar to above, except window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.

BUG=613182

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed
announcements, ChromeVox can compute output that takes into account eh focused
node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab
title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally
the window gets read
ctrl+tab: similar to above, except window isn't included (diff of ancestry
chains). This cleaned up some of the previous hacks to focus the root web area.
Selection had been set to the tab node; now, ensure the selection target is a
descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page
programmatically sets it at around load time. The tabs api handler logic reads
out the tab using the url since it has nothing at creation time.

BUG=613182

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c
Cr-Commit-Position: refs/heads/master@{#396314}
==========

[commit-bot: I haz the power, 2016-05-26 23:27:52]

Patchset 7 (id:??) landed as
https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c
Cr-Commit-Position: refs/heads/master@{#396314}