Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ui/views/accessibility/ax_window_obj_wrapper.cc

Issue 2008773002: Begin using ChromeVox Next to read tab and window titles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a bunch of tests. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/accessibility/ax_widget_obj_wrapper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/accessibility/ax_window_obj_wrapper.cc
diff --git a/ui/views/accessibility/ax_window_obj_wrapper.cc b/ui/views/accessibility/ax_window_obj_wrapper.cc
index ebdb650d1a6b484f523067246ef311ad81963963..c96457318e0930101f54e045b8de0fc7ccd69b7d 100644
--- a/ui/views/accessibility/ax_window_obj_wrapper.cc
+++ b/ui/views/accessibility/ax_window_obj_wrapper.cc
@@ -50,16 +50,10 @@ void AXWindowObjWrapper::GetChildren(
void AXWindowObjWrapper::Serialize(ui::AXNodeData* out_node_data) {
out_node_data->id = GetID();
out_node_data->role = is_alert_ ? ui::AX_ROLE_ALERT : ui::AX_ROLE_WINDOW;
- // TODO(dtseng): Set better states.
+ out_node_data->AddStringAttribute(ui::AX_ATTR_NAME,
+ base::UTF16ToUTF8(window_->title()));
out_node_data->state = 0;
out_node_data->location = window_->bounds();
-
- // Root windows currently have a non readable name (e.g. Display1234...);
- // ignore them unless the window is the only node in the tree.
- if (window_->parent() || window_->children().size() == 0) {
- out_node_data->AddStringAttribute(ui::AX_ATTR_NAME,
- base::UTF16ToUTF8(window_->title()));
- }
}
int32_t AXWindowObjWrapper::GetID() {
« no previous file with comments | « ui/views/accessibility/ax_widget_obj_wrapper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698