Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2016003002: Collapse description into either value or name, and value into name if duplicated. (Closed)

Created:
4 years, 7 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@read_window_chain
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Collapse description into either value or name, and value into name if duplicated. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation TEST=BackgroundTest.ButtonNameValueDescription BUG=613639 Committed: https://crrev.com/3a3d7b8373fa37a6342b13d0857f1e99ca983dec Cr-Commit-Position: refs/heads/master@{#399035}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Test fixes and cleanup. #

Patch Set 4 : More test fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -103 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 2 15 chunks +121 lines, -100 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
David Tseng
4 years, 7 months ago (2016-05-26 19:10:17 UTC) #4
David Tseng
On 2016/05/26 19:10:17, David Tseng wrote: Friendly ping
4 years, 6 months ago (2016-05-31 18:40:18 UTC) #5
dmazzoni
lgtm
4 years, 6 months ago (2016-06-03 16:07:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016003002/20001
4 years, 6 months ago (2016-06-03 16:08:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/180628)
4 years, 6 months ago (2016-06-03 16:57:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016003002/40001
4 years, 6 months ago (2016-06-09 18:25:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/183700)
4 years, 6 months ago (2016-06-09 19:30:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016003002/60001
4 years, 6 months ago (2016-06-09 21:20:54 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-09 22:08:42 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 22:11:12 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3a3d7b8373fa37a6342b13d0857f1e99ca983dec
Cr-Commit-Position: refs/heads/master@{#399035}

Powered by Google App Engine
This is Rietveld 408576698