chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 2008773002: Begin using ChromeVox Next to read tab and window titles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 2008773002: Begin using ChromeVox Next to read tab and window titles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a bunch of tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index f43000423454edc5b8f58db6d14475c716952c65..b0c3985cf3393046d40f2a915132a80aa1e78e53 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -254,8 +254,12 @@ Background.prototype = {

if (mode === ChromeVoxMode.NEXT ||

mode === ChromeVoxMode.FORCE_NEXT) {

(new PanelCommand(PanelCommandType.ENABLE_MENUS)).send();

+ if (cvox.TabsApiHandler)

+ cvox.TabsApiHandler.shouldOutputSpeechAndBraille = false;

} else {

(new PanelCommand(PanelCommandType.DISABLE_MENUS)).send();

+ if (cvox.TabsApiHandler)

+ cvox.TabsApiHandler.shouldOutputSpeechAndBraille = true;

}

// If switching to Classic from any automation-API-based mode,

@@ -318,7 +322,9 @@ Background.prototype = {

* @override

getCurrentRange: function() {

- return this.currentRange_;

+ if (this.currentRange_ && this.currentRange_.isValid())

+ return this.currentRange_;

+ return null;

/**